Absolute import instead of relative #479

ahijevyc · 2024-12-17T21:50:59Z

For 3 scripts in metplotpy/contributed/fv3_physics_tend...

Follow the style of metplotpy module importing that is used in metplotpy/contributed/stratosphere_diagnostics/stratosphere_diagnostics.py to avoid error about relative import.

In other words, replace from . import physics_tend
with import metplotpy.contributed.fv3_physics_tend.physics_tend

That should avoid the
ImportError: attempted relative import with no known parent package.

Pull Request Testing

Describe testing already performed for these changes:

It works in a conda environment with metplotpy 2.1.0

Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

setenv METPLOTPY_BASE <path>
setenv CONFIG $METPLOTPY_BASE/test/fv3_physics_tend/fv3_physics_tend_defaults.yaml
setenv WORKING_DIR $METPLOTPY_BASE/metplotpy/contributed/fv3_physics_tend
cd $WORKING_DIR
python planview_fv3.py -h

Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]

If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]

If yes, please describe:
Please complete this pull request review by [February 2025].

Pull Request Checklist

See the METplus Workflow for details.

[ x] Add any new Python packages to the METplus Components Python Requirements table.
[x ] Review the source issue metadata (required labels, projects, and milestone).
[x ] Complete the PR definition above.
[x ] Ensure the PR title matches the feature or bugfix branch name.
[ x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
Close the linked issue and delete your feature or bugfix branch from GitHub.

set up for beta1 development

update dates for 3.0 release

Replace link from boxplot to series plot

* Issue #386 * Issue #386

set up for beta2 development

* Issue #391 utils for added fixed_vars_vals_input support * Issue #391 tests for plot correctness. Includes data, config file, expected plot, and expected data points * fix formatting * Issue #391 add support to read in fixed_vars_vals_input setting * Issue #391 perform filtering if fixed_vars_vals_input has any values defined * issue #391 update to support the legacy format expected by METviewer when R was in use or a more simplified format for defining the fixed_vars_vals_input setting * Issue #391 clean up tests, update config files * issue #391 update the syntax for setting the fixed_vars_vals_input * add issue to branch name to activate documentation workflow * issue 391 updates to query, log when query returns an empty string * issue #391 don't filter when the query string is an empty string * Issue #391 remove call to non-existent logger in the create_query function --------- Co-authored-by: Julie Prestopnik <[email protected]>

…iability diagram #465 (#393)

* Issue #391 utils for added fixed_vars_vals_input support * Issue #391 tests for plot correctness. Includes data, config file, expected plot, and expected data points * fix formatting * Issue #391 add support to read in fixed_vars_vals_input setting * Issue #391 perform filtering if fixed_vars_vals_input has any values defined * issue #391 update to support the legacy format expected by METviewer when R was in use or a more simplified format for defining the fixed_vars_vals_input setting * Issue #391 clean up tests, update config files * issue #391 update the syntax for setting the fixed_vars_vals_input * add issue to branch name to activate documentation workflow * issue 391 updates to query, log when query returns an empty string * issue #391 don't filter when the query string is an empty string * Issue #391 remove call to non-existent logger in the create_query function * Issue #391 invoke filter_by_fixed_vars in metplotpy.util to filter by fixed vars * Issue #391 replace create_query() with filter_by_fixed_vars() * Issue #391 replace tests for create_query with tests for filter_by_vars * issue #391 data for filtering by fixed vals * Issue #391 additional test for filtering by fixed values * issue #391 fixed formatting that was causing unexpected results, updated comments --------- Co-authored-by: Julie Prestopnik <[email protected]>

* Fix title to reflect the actual data used * Change title to reflect the data used * Issue #394 Suppress deprecation warning emanating from python-kaleido/plotly * Remove save_to_file(), use version in base_plot --------- Co-authored-by: Minna Win-Gildenmeister <[email protected]>

* Issue #401 replaced line_logger with logger in line 698 * issue #401 don't remove the nan.points1 plot as cleanup * Issue #401 move this file from the intermediate files directory. It doesn't belong there since it is not created during a test and is a file that is supposed to persist * issue #401 refer to the nan.points1 in a new directory

* hide/show the legend entries line by line #355 * add show_legend parameter to the config files for testing #355 * commented show_in_browser #355

* Issue #403 updated release notes for beta2 * Issue #403 updated version for beta2 release * Issue #403 fixed typo * Issue #403 update date

update for beta3 development

update description of ArgumentParser to be more generic.

* data for testing ROC summary curve #399 * add a legend for ROC summary curve #399 * add ROC summary curve #399 * add ROC summary curve #399 * add ROC summary curve parameter #399 * add ROC summary curve #399 * add ROC summary curve test #399 * move methods for preparing ROC data to the common script for the ease of reuse #399

Fix typo.

* Adding stratosphere bias plot * Added stratosphere Plots * Added stratosphere plots for new use cases * Added plotting documentation * Updated toctree

* command line updates * updating yaml files

scipy 1.9.3 no longer available in conda forge, use the same version as in requirements.txt

replace == with >= for scipy to allow flexibility

* updates to version and release notes * Fix misspelling

forgot to update the header for beta3 (had copied and pasted from beta2)

update version for beta4 development

* Revert "Feature 461 make compare images configurable (#467)" This reverts commit 5c189be. * 461: keep CompareImages in conftest

…recationWarning, as it no longer exists

…e tests when changes are pushed to main_vX.Y and develop branches

* fix version number for rc1 * get version number from verison file * per #475, add default config files to python package * prevent GPU failure running in containers by running kaleido with single process option

* updates for coordinated release: version updates, dates, rotating authors * Clean up text: fix typos, remove duplicates * Update vulnerabilities.yaml update gh-action-pip-audit from 1.0.5 to 1.1.0 * Apply suggestions from code review Co-authored-by: Julie Prestopnik <[email protected]> * Adding space * Removing, superfluous since vulnerability checks are automatically done --------- Co-authored-by: Julie Prestopnik <[email protected]>

added the version number

fixed version number

version number needs quotes

…ed in METviewer

…s captured in METviewer" This reverts commit b273d4b.

…version numbers (#411)

for files in metplotpy/contributed/fv3_physics_tend

bikegeek and others added 30 commits August 1, 2023 15:43

Update version

8f0b97d

set up for beta1 development

Update conf.py

a4927f3

update dates for 3.0 release

Replace link from boxplot to series plot

9c82f83

Merge pull request #387 from dtcenter/feature_385_documentation

07b2f39

Replace link from boxplot to series plot

Feature 386 v3.0.0 beta1 (#389)

4b7aaf3

* Issue #386 * Issue #386

Update version

d6f3a26

set up for beta2 development

Update release-notes.rst to add "-beta1"

2c29682

Update and rename 2.1.0_wcoss2 to 3.0.0_wcoss2

eb3e20c

Update requirements.txt

c42cf1e

Added sphinx_rtd_theme to extensions

cfd2335

specify the color of the no resolution and no skill lines for the rel…

f635ce4

…iability diagram #465 (#393)

Issue 355 show legend (#400)

d55d837

* hide/show the legend entries line by line #355 * add show_legend parameter to the config files for testing #355 * commented show_in_browser #355

Feature 403 v3.0.0 beta2 (#404)

d2025c7

* Issue #403 updated release notes for beta2 * Issue #403 updated version for beta2 release * Issue #403 fixed typo * Issue #403 update date

move content to the correct section (#406)

5e0ea1f

Update version

7929cbb

update for beta3 development

Update util.py

acbcdc5

update description of ArgumentParser to be more generic.

Update index.rst

2f3d9d4

Fix typo.

Feature 407 stratosphere bias plot (#410)

16ac0f8

* Adding stratosphere bias plot * Added stratosphere Plots * Added stratosphere plots for new use cases * Added plotting documentation * Updated toctree

feature_414_develop_gha_node20 (#415)

634049b

* command line updates * updating yaml files

Update nco_requirements.txt

8531352

scipy 1.9.3 no longer available in conda forge, use the same version as in requirements.txt

Update requirements.txt

acfe80a

replace == with >= for scipy to allow flexibility

Feature 419 v3.0.0 beta3 (#422)

1c350fa

* updates to version and release notes * Fix misspelling

Update release-notes.rst

9bcd854

forgot to update the header for beta3 (had copied and pasted from beta2)

Update version

40b2fd1

update version for beta4 development

adding a literalinclude (#420)

0ca9427

John-Sharples and others added 7 commits October 31, 2024 11:52

461 revert compare images changes (#472)

3e6022c

* Revert "Feature 461 make compare images configurable (#467)" This reverts commit 5c189be. * 461: keep CompareImages in conftest

Replace matplotlib.cbook.mplDeprecation with matplotlib.MatplotlibDep…

b3ca7b2

…recationWarning, as it no longer exists

Updated dates and added release notes for rc1 (#474)

62fc8d0

Update conf.py

0723459

Per dtcenter/METplus#2336, call custom GHA to trigger METplus use cas…

d41facd

…e tests when changes are pushed to main_vX.Y and develop branches

Bugfix #475 main_v3.0 - make default configs available in package (#477)

e058faa

* fix version number for rc1 * get version number from verison file * per #475, add default config files to python package * prevent GPU failure running in containers by running kaleido with single process option

Adding In Memoriam

08a315c

ahijevyc added type: bug Fix something that is not working priority: low Low Priority labels Dec 17, 2024

ahijevyc added this to the METplotpy-2.1.1 (bugfix) milestone Dec 17, 2024

ahijevyc requested a review from bikegeek December 17, 2024 21:50

ahijevyc linked an issue Dec 17, 2024 that may be closed by this pull request

import metplotpy.contributed... instead of relative import #478

Open

14 tasks

ahijevyc removed a link to an issue Dec 17, 2024

import metplotpy.contributed... instead of relative import #478

Open

14 tasks

ahijevyc linked an issue Dec 17, 2024 that may be closed by this pull request

import metplotpy.contributed... instead of relative import #478

Open

14 tasks

bikegeek and others added 5 commits December 18, 2024 16:04

Removing, superfluous since Github automatically checks

3fa6af6

Update conf.py

1ba6ef7

added the version number

Update conf.py

87a2891

fixed version number

Update conf.py

91cff36

version number needs quotes

michelleharrold modified the milestones: METplotpy-2.1.1 (bugfix), METplotpy-3.1.0 Jan 8, 2025

michelleharrold added reporting: DTC NCAR Base NCAR Base DTC Project and removed reporting: DTC NCAR Base NCAR Base DTC Project labels Jan 8, 2025

bikegeek and others added 5 commits January 17, 2025 15:02

Modified default log level to ERROR to reduce logging messages captur…

faed435

…ed in METviewer

Revert "Modified default log level to ERROR to reduce logging message…

9c4dda9

…s captured in METviewer" This reverts commit b273d4b.

Create 2.1.0_casper

96184f6

update documentation requirements to include all sphinx packages and …

a685022

…version numbers (#411)

Absolute import instead of relative

7edf1ec

for files in metplotpy/contributed/fv3_physics_tend

ahijevyc force-pushed the 478-import-metplotpycontributed-instead-of-relative-import branch from ae7d2ca to 7edf1ec Compare January 17, 2025 22:18

ahijevyc closed this Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Absolute import instead of relative #479

Absolute import instead of relative #479

ahijevyc commented Dec 17, 2024 •

edited

Loading

Absolute import instead of relative #479

Absolute import instead of relative #479

Conversation

ahijevyc commented Dec 17, 2024 • edited Loading

Pull Request Testing

Pull Request Checklist

ahijevyc commented Dec 17, 2024 •

edited

Loading