Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix478 import from metplotpy.contributed instead of relative import #483

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

ahijevyc
Copy link
Contributor

@ahijevyc ahijevyc commented Jan 18, 2025

Pull Request Testing

  • git checkout 478-import-metplotpycontributed-instead-of-relative-import
  • Install metplotpy-3.0.0rc1
  • setenv METPLOTPY_BASE $SCRATCH/METplotpy
  • cd $METPLOTPY_BASE
  • python ./metplotpy/contributed/fv3_physics_tend/cross_section_vert.py -h

This should return a usage statement, not ImportError: attempted relative import with no known parent package.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 18 commits November 14, 2024 14:37
…e tests when changes are pushed to main_vX.Y and develop branches
* fix version number for rc1

* get version number from verison file

* per #475, add default config files to python package

* prevent GPU failure running in containers by running kaleido with single process option
* updates for coordinated release: version updates, dates, rotating authors

* Clean up text: fix typos, remove duplicates

* Update vulnerabilities.yaml

update gh-action-pip-audit from 1.0.5 to 1.1.0

* Apply suggestions from code review

Co-authored-by: Julie Prestopnik <[email protected]>

* Adding space

* Removing, superfluous since vulnerability checks are automatically done

---------

Co-authored-by: Julie Prestopnik <[email protected]>
added the version number
fixed version number
version number needs quotes
for files in metplotpy/contributed/fv3_physics_tend
@ahijevyc ahijevyc added type: bug Fix something that is not working priority: medium Medium Priority component: code cleanup Code cleanup and maintenance issue requestor: NCAR/MMM NCAR Meso and Microscale Meteorology Laboratory METplotpy: Plots labels Jan 18, 2025
@ahijevyc ahijevyc requested a review from bikegeek January 18, 2025 22:53
@ahijevyc ahijevyc self-assigned this Jan 18, 2025
@ahijevyc ahijevyc linked an issue Jan 18, 2025 that may be closed by this pull request
14 tasks
@ahijevyc
Copy link
Contributor Author

I closed an old PR linked to metplotpy version 2 and opened this one linked to main_v3.0. Along the way I over-complicated the commits, but ultimately, the PR is relatively clean; it has only 3 lines that differ from branch main_v3.0. Specifically, the physics_tend import statement is changed in three python scripts under the contributed.fv3_physics_tend directory.

@ahijevyc ahijevyc changed the base branch from main_v3.0 to develop January 19, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: code cleanup Code cleanup and maintenance issue METplotpy: Plots priority: medium Medium Priority requestor: NCAR/MMM NCAR Meso and Microscale Meteorology Laboratory type: bug Fix something that is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import metplotpy.contributed... instead of relative import
4 participants