Skip to content

Commit

Permalink
Feature #521 main_v5.1 sonarqube_properties (#529)
Browse files Browse the repository at this point in the history
* Per #521, same sonar-project.properties changes but for the main_v5.1 branch

* Per #521, based on feedback from Tatiana, exclude the METviewer test directory from the scan and code coverage computations.

* Per #521, try specifying the file exclusions rather than top-level directories
  • Loading branch information
JohnHalleyGotway authored Apr 24, 2024
1 parent 16096d7 commit 3a04975
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/jobs/build_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if [ $? != 0 ]; then
exit 1
fi

# Copy the dist directory from the image
# Copy the build directory from the image
id=$(docker create ${DOCKERHUB_TAG})
time_command docker cp $id:/METviewer/dist dist
time_command docker cp $id:/METviewer/build build
docker rm -v $id
6 changes: 4 additions & 2 deletions internal/scripts/sonarqube/sonar-project.properties
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ sonar.projectName=METviewer
sonar.projectVersion=SONAR_PROJECT_VERSION
sonar.branch.name=SONAR_BRANCH_NAME
sonar.sources=java
sonar.java.libraries=dist/lib
sonar.java.binaries=dist/metviewer/WEB-INF/classes
sonar.java.libraries=lib
sonar.java.binaries=build
sonar.sourceEncoding=UTF-8
sonar.exclusions=java/edu/ucar/metviewer/test/*,java/edu/ucar/metviewer/test/**/*
sonar.coverage.exclusions=java/edu/ucar/metviewer/test/*,java/edu/ucar/metviewer/test/**/*

# SonarQube server
sonar.host.url=SONAR_HOST_URL
Expand Down

0 comments on commit 3a04975

Please sign in to comment.