Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for the implementation of OBJCSI and OBJACSI MODE statistics to m… #519

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

TatianaBurek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    tested on dakota (job #20240215_190637). This job produced the expected statistics values that were calculated by Tina in MODE Object CSI vs Object Area CSI in METviewer METplus#2496 (reply in thread)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…atch the definition listed in the MET documentation #516
@TatianaBurek TatianaBurek added this to the METviewer-6.0.0 milestone Feb 15, 2024
@TatianaBurek TatianaBurek linked an issue Feb 15, 2024 that may be closed by this pull request
22 tasks
Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to code are consistent with suggested fix in Github Discussion

@TatianaBurek TatianaBurek merged commit 324580d into develop Feb 15, 2024
2 checks passed
@TatianaBurek TatianaBurek deleted the issue_516_mode_csi branch February 15, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

MODE CSI statistics produces spurious results
2 participants