Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #521 main_v5.1 sonarqube_properties #529

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Feature #521 main_v5.1 sonarqube_properties #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23cfe5f
Per #521, same sonar-project.properties changes but for the main_v5.1…
JohnHalleyGotway Apr 23, 2024
028a74f
Per #521, based on feedback from Tatiana, exclude the METviewer test …
JohnHalleyGotway Apr 24, 2024
ad38bcb
Per #521, try specifying the file exclusions rather than top-level di…
JohnHalleyGotway Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/jobs/build_docker_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if [ $? != 0 ]; then
exit 1
fi

# Copy the dist directory from the image
# Copy the build directory from the image
id=$(docker create ${DOCKERHUB_TAG})
time_command docker cp $id:/METviewer/dist dist
time_command docker cp $id:/METviewer/build build
docker rm -v $id
6 changes: 4 additions & 2 deletions internal/scripts/sonarqube/sonar-project.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ sonar.projectName=METviewer
sonar.projectVersion=SONAR_PROJECT_VERSION
sonar.branch.name=SONAR_BRANCH_NAME
sonar.sources=java
sonar.java.libraries=dist/lib
sonar.java.binaries=dist/metviewer/WEB-INF/classes
sonar.java.libraries=lib
sonar.java.binaries=build
sonar.sourceEncoding=UTF-8
sonar.exclusions=java/edu/ucar/metviewer/test/*,java/edu/ucar/metviewer/test/**/*
sonar.coverage.exclusions=java/edu/ucar/metviewer/test/*,java/edu/ucar/metviewer/test/**/*

# SonarQube server
sonar.host.url=SONAR_HOST_URL
Expand Down