-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 491 develop update templates #531
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the METviewer v6.0.0-beta1 release #492
Issue 494 xml load
add error messages to GUI Log output #495
Reorganise results tabs in METviewer UI #387
specify the color of the no resolution and no skill lines for the reliability diagram #465
* fixing headers, adding Contributors Guide to the index file * removing Contributors Guide. It crashed. * updating headers and some titles with capitalizing * changing Template Formatting to it's own section * Adding Contributors Guide to make it viewable * Removing Contributor's Guide from exclude_patterns * Update docs/Users_Guide/installation.rst Co-authored-by: Julie Prestopnik <[email protected]> * Update docs/Users_Guide/web_service.rst Co-authored-by: Julie Prestopnik <[email protected]> * Update docs/Users_Guide/web_service.rst Co-authored-by: Julie Prestopnik <[email protected]> * fixing header underline * returning headers to their original state * Changing Index header back to its original state --------- Co-authored-by: Julie Prestopnik <[email protected]>
hide/show the legend entries line by line #501
Create the METviewer v6.0.0-beta2 release #504
Add summary_curve parameter to ROC YAML #506
add accessibility statement #508
Create the METviewer v6.0.0-beta3
…atch the definition listed in the MET documentation #516
fix for the implementation of OBJCSI and OBJACSI MODE statistics to m…
Bugfix for loading xml #513
Corrected the linetype needed from SL1L2 to CNT
Beta4 release
Updated files for beta5
* Per #521, add hooks for a SonarQube GHA workflow. * Per #521, fix cut/paste error configure_sonarqube.sh * Per #521, hard-code the Sonar Project key and name in the properties file since we're using the same project for all scans. * Per #521, setup build_sonar.xml configuration by referencing environment variables. * work in progress * Per #521, move docker directory into internal/scripts for consistency across METplus repos * Per #521, work in progress. * Per #521, switch to running the sonar-scanner. * Per #521, still working on the details * Whitespace changes * Per #521, try turning on the sonarqube workflow for this feature branch. * Per #521, try turning on the sonarqube workflow for this feature branch. * Per #521, try to save the logs * Per #521, print the environment for debugging * Per #521, define missing DOCKERHUB_REPO and SOURCE_BRANCH envvars * Per #521, working on Dockerfile.copy * Per #521, use hard-coded /METviewer directory instead of to avoid inconsistent use of an environment variable. * Per #521, METVIEWER_GIT_NAME is set as SOURCE_BRANCH rather than being a required envvar. * Per #521, syntax * Per #521, consistency of Dockerfiles. * Per #521, remove feature_521_develop_sonarqube_gha branch name from sonarqube.xml I'd added to use for testing. * Per #521, singularity is named apptainer, as of 2021 * Per #521, more work is needed in the DockerHub build hook. For now, switch to building against the develop version of the dependencies.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Reviewed the changes. These changes are based off of the work from this MET issue to improve the issue and pull request templates.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the changes.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [None needed]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [20240521].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes