Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 491 develop update templates #531

Closed
wants to merge 46 commits into from

Conversation

jprestop
Copy link
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Reviewed the changes. These changes are based off of the work from this MET issue to improve the issue and pull request templates.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [None needed]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [20240521].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

TatianaBurek and others added 30 commits September 11, 2023 11:33
Create the METviewer v6.0.0-beta1 release  #492
add error messages to GUI Log output  #495
Reorganise results tabs in METviewer UI #387
specify the color of the no resolution and no skill lines for the reliability diagram #465
* fixing headers, adding Contributors Guide to the index file

* removing Contributors Guide. It crashed.

* updating headers and some titles with capitalizing

* changing Template Formatting to it's own section

* Adding Contributors Guide to make it viewable

* Removing Contributor's Guide from exclude_patterns

* Update docs/Users_Guide/installation.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Users_Guide/web_service.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* Update docs/Users_Guide/web_service.rst

Co-authored-by: Julie Prestopnik <[email protected]>

* fixing header underline

* returning headers to their original state

* Changing Index header back to its original state

---------

Co-authored-by: Julie Prestopnik <[email protected]>
 hide/show the legend entries line by line #501
Create the METviewer v6.0.0-beta2 release #504
Add summary_curve parameter to ROC YAML #506
TatianaBurek and others added 16 commits February 8, 2024 12:44
…atch the definition listed in the MET documentation #516
fix for the implementation of OBJCSI and OBJACSI MODE statistics to m…
Corrected the linetype needed from SL1L2 to CNT
* Per #521, add hooks for a SonarQube GHA workflow.

* Per #521, fix cut/paste error configure_sonarqube.sh

* Per #521, hard-code the Sonar Project key and name in the properties file since we're using the same project for all scans.

* Per #521, setup build_sonar.xml configuration by referencing environment variables.

* work in progress

* Per #521, move docker directory into internal/scripts for consistency across METplus repos

* Per #521, work in progress.

* Per #521, switch to running the sonar-scanner.

* Per #521, still working on the details

* Whitespace changes

* Per #521, try turning on the sonarqube workflow for this feature branch.

* Per #521, try turning on the sonarqube workflow for this feature branch.

* Per #521, try to save the logs

* Per #521, print the environment for debugging

* Per #521, define missing DOCKERHUB_REPO and SOURCE_BRANCH envvars

* Per #521, working on Dockerfile.copy

* Per #521, use hard-coded /METviewer directory instead of  to avoid inconsistent use of an environment variable.

* Per #521, METVIEWER_GIT_NAME is set as SOURCE_BRANCH rather than being a required envvar.

* Per #521, syntax

* Per #521, consistency of Dockerfiles.

* Per #521, remove feature_521_develop_sonarqube_gha branch name from sonarqube.xml I'd added to use for testing.

* Per #521, singularity is named apptainer, as of 2021

* Per #521, more work is needed in the DockerHub build hook. For now, switch to building against the develop version of the dependencies.
* Per #521, modify the METviewer sonarqube properties for a more complete scan.

* Per #521, based on feedback from Tatiana, exclude the METviewer test directory from the scan and code coverage computations.

* Per #521, try specifying the file exclusions rather than top-level directories
@jprestop jprestop added this to the METviewer-6.0.0 milestone May 16, 2024
@jprestop jprestop requested a review from bikegeek May 16, 2024 19:38
@jprestop jprestop closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Update GitHub issue and pull request templates to reflect the current development workflow details
5 participants