Fix : Images getting cropped when help center is active in small devices #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aritradevelops is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
@steven-tey please have a look, thanks! |
steven-tey
approved these changes
Oct 21, 2024
|
amazing fix and writeup! |
|
Awarding aritradevelops: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/aritradevelops |
|
/award 300 |
|
Awarding aritradevelops: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/aritradevelops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
Issue
In small devices when opening the help center the top level div of the New Background Component was shrinking its size down and was not starting itself from top:0, therefore the images inside that was also starting from that level, which to user, seems like the image is getting cropped.
Images
What does this PR do
changing its position from absolute to fixed sticks it to the top always, therefore the image will start from the top and look normal
Images
How to test this
Oss
As you can see many people have already tried fixing it and it was not a easy to find issue so I would request you to award a bit more point for this fix, thanks in advance!