Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename s/plumbing/semver_unstable, hide in docs #186

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

nikomatsakis
Copy link
Member

Easy review

r? @rcoh

@rcoh
Copy link
Contributor

rcoh commented Oct 1, 2024

the one thing that I'm worried about here is that currently the macros package is pinned to the same version as everything else. Naming it this makes it sounds like you could make breaking changes to it without releasing a new major version of duchess (but you can't in practice).

We actually can't make a breaking change in the macro package today because an older version of duchess would pick up the new macro package.

It might be worth taking care of that versioning before we accidentally cause a semver break later.

@nikomatsakis nikomatsakis merged commit 0b2975a into duchess-rs:main Oct 1, 2024
13 checks passed
@nikomatsakis
Copy link
Member Author

Ah. Yes, the macro crates should just be versioned with an independent integer (1.0, 2.0, 3.0, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants