pretty-close-to-build-rs #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcoh I'm finally getting around to reading this -- is it possible you forgot to add |
Moves javap into build.rs. Error handling works pretty well. There is one missing piece to also capture `#[java...]` derives since those must also be reflected in build.rs.
nikomatsakis
approved these changes
Dec 26, 2024
duchess-build-rs/src/derive_java.rs
Outdated
| reflector: &mut duchess_reflect::reflect::JavapReflector, | ||
| ) -> anyhow::Result<bool> { | ||
| let mut watch_file = false; | ||
| eprintln!("Looking for derive(java) in {:?}", rs_file.path); |
There was a problem hiding this comment.
Suggested change
| eprintln!("Looking for derive(java) in {:?}", rs_file.path); |
duchess-build-rs/src/derive_java.rs
Outdated
| let mut watch_file = false; | ||
| eprintln!("Looking for derive(java) in {:?}", rs_file.path); | ||
| for capture in re::java_derive().captures_iter(&rs_file.contents) { | ||
| eprintln!("Debug: found derive(java) in {:?}", rs_file.path); |
There was a problem hiding this comment.
Suggested change
| eprintln!("Debug: found derive(java) in {:?}", rs_file.path); |
| pub fn process_file(rs_file: &File, reflector: &mut JavapReflector) -> anyhow::Result<bool> { | ||
| let mut watch_file = false; | ||
| for capture in re::java_package().captures_iter(&rs_file.contents) { | ||
| eprintln!("Debug: found java macro in {:?}", rs_file.path); |
There was a problem hiding this comment.
Suggested change
| eprintln!("Debug: found java macro in {:?}", rs_file.path); |
|
Yeah I have a revision locally that changes them to optional warnings so
you can see them in cargo. Will push that this morning
…On Thu, Dec 26, 2024, 10:29 AM Niko Matsakis ***@***.***> wrote:
***@***.**** approved this pull request.
This makes sense to me -- I was removing eprintln! statements but I
realized maybe you're not quite ready for this to land.
------------------------------
In duchess-build-rs/src/derive_java.rs
<#188 (comment)>:
> +use duchess_reflect::{
+ argument::MethodSelector,
+ parse::{Parse, Parser},
+ reflect::Reflect,
+};
+use proc_macro2::Span;
+use syn::{parse::ParseStream, Attribute};
+
+use crate::re;
+
+pub(crate) fn process_file(
+ rs_file: &crate::files::File,
+ reflector: &mut duchess_reflect::reflect::JavapReflector,
+) -> anyhow::Result<bool> {
+ let mut watch_file = false;
+ eprintln!("Looking for derive(java) in {:?}", rs_file.path);
⬇️ Suggested change
- eprintln!("Looking for derive(java) in {:?}", rs_file.path);
------------------------------
In duchess-build-rs/src/derive_java.rs
<#188 (comment)>:
> + parse::{Parse, Parser},
+ reflect::Reflect,
+};
+use proc_macro2::Span;
+use syn::{parse::ParseStream, Attribute};
+
+use crate::re;
+
+pub(crate) fn process_file(
+ rs_file: &crate::files::File,
+ reflector: &mut duchess_reflect::reflect::JavapReflector,
+) -> anyhow::Result<bool> {
+ let mut watch_file = false;
+ eprintln!("Looking for derive(java) in {:?}", rs_file.path);
+ for capture in re::java_derive().captures_iter(&rs_file.contents) {
+ eprintln!("Debug: found derive(java) in {:?}", rs_file.path);
⬇️ Suggested change
- eprintln!("Debug: found derive(java) in {:?}", rs_file.path);
------------------------------
In duchess-build-rs/src/java_package_macro.rs
<#188 (comment)>:
>
-pub fn process_macro(compiler: &JavaCompiler, file: &File, offset: usize) -> anyhow::Result<()> {
- let the_impl: JavaPackageMacro = syn::parse_str(file.rust_slice_from(offset))
- .with_context(|| format!("{} failed to parse java_package macro", file.slug(offset),))?;
+pub fn process_file(rs_file: &File, reflector: &mut JavapReflector) -> anyhow::Result<bool> {
+ let mut watch_file = false;
+ for capture in re::java_package().captures_iter(&rs_file.contents) {
+ eprintln!("Debug: found java macro in {:?}", rs_file.path);
⬇️ Suggested change
- eprintln!("Debug: found java macro in {:?}", rs_file.path);
—
Reply to this email directly, view it on GitHub
<#188 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZ56VOE7XITGLKLI6ST2HQOGRAVCNFSM6AAAAABROLJVKWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRTGI4DQNJWGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves javap into build.rs. Error handling works pretty well. There is one missing piece to also capture
#[java...]derivessince those must also be reflected in build.rs.