Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't pass default schema name to schema filter in SQLTables #26

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix: Don't pass default schema name to schema filter in SQLTables #26

merged 2 commits into from
Aug 23, 2024

Conversation

guenp
Copy link
Collaborator

@guenp guenp commented Jul 24, 2024

Fixes #25

maiadegraaf
maiadegraaf requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@maiadegraaf maiadegraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you add a small test that shows that tables not in the main schema are returned.

@guenp guenp force-pushed the guenp/fix-get-tables branch from 277f08a to eebef3a Compare August 19, 2024 17:10
@guenp guenp mentioned this pull request Aug 19, 2024
Closed
@guenp guenp requested a review from maiadegraaf August 21, 2024 05:40
maiadegraaf
maiadegraaf approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@maiadegraaf maiadegraaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests! LGTM :)

@maiadegraaf maiadegraaf merged commit 40d6776 into duckdb:main Aug 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiadegraaf maiadegraaf maiadegraaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Power BI] GetTables returns only tables in main schema when not specifying a schema
2 participants
@guenp @maiadegraaf