Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serialization of primitives in Response #120

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Dec 19, 2024

Checklist

  • The code has 100% test coverage.
  • The documentation was properly created or updated (if applicable) following the correct guidelines and appropriate language.
  • I branched out from the latest main or is a sub-branch.

Summary or description

Before:

When passing e.g. an int or float as a content in make_response and using a normal Response a crash was the result.

After:

Handle everything gracefully.

This bug is old but was only exposed by a new test.

@devkral devkral force-pushed the devkral/fixes/serialization_of_primitives_in_Response branch from be201f8 to 3733b17 Compare December 19, 2024 11:52
@tarsil tarsil merged commit cfb9701 into main Dec 20, 2024
4 checks passed
@tarsil tarsil deleted the devkral/fixes/serialization_of_primitives_in_Response branch December 20, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants