Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support extended position mode #98

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,13 @@ Note that `joint_ids` parameters must be splited by `,`.
<param name="usb_port">/dev/ttyUSB0</param>
<param name="baud_rate">1000000</param>
<!-- <param name="use_dummy">true</param> -->
<param name="extended_mode">false</param> <!-- Set true if you use the extended position mode of Dynamixel motors -->
Tacha-S marked this conversation as resolved.
Show resolved Hide resolved
</hardware>
```

Note that the `extended_mode` parameter is optional and set to `false` by default.
If you use the extended position (multi turn) mode of Dynamixel motors, set it to `true`.

Tacha-S marked this conversation as resolved.
Show resolved Hide resolved
- Terminal 1

Launch the `ros2_control` manager for the OpenManipulator-X.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ class DynamixelHardware : public hardware_interface::SystemInterface
ControlMode control_mode_{ControlMode::Position};
bool mode_changed_{false};
bool use_dummy_{false};
bool is_extended_mode_{false};
};
} // namespace dynamixel_hardware

Expand Down
39 changes: 36 additions & 3 deletions dynamixel_hardware/src/dynamixel_hardware.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,12 @@ CallbackReturn DynamixelHardware::on_init(const hardware_interface::HardwareInfo
}
}

if (info_.hardware_parameters.find("extended_mode") != info_.hardware_parameters.end()) {
is_extended_mode_ = info_.hardware_parameters.at("extended_mode") == "true" ||
info_.hardware_parameters.at("extended_mode") == "1";
}
enable_torque(false);
set_control_mode(ControlMode::Position, true);
set_control_mode(is_extended_mode_ ? ControlMode::ExtendedPosition : ControlMode::Position, true);
set_joint_params();
enable_torque(true);

Expand Down Expand Up @@ -326,7 +330,7 @@ return_type DynamixelHardware::write(
return j.command.position != j.prev_command.position;
}))
{
set_control_mode(ControlMode::Position);
set_control_mode(is_extended_mode_ ? ControlMode::ExtendedPosition : ControlMode::Position);
if (mode_changed_) {
set_joint_params();
}
Expand All @@ -350,6 +354,7 @@ return_type DynamixelHardware::write(
return return_type::OK;
break;
case ControlMode::Position:
case ControlMode::ExtendedPosition:
set_joint_positions();
return return_type::OK;
break;
Expand Down Expand Up @@ -440,7 +445,35 @@ return_type DynamixelHardware::set_control_mode(const ControlMode & mode, const
return return_type::OK;
}

if (control_mode_ != ControlMode::Velocity && control_mode_ != ControlMode::Position) {
if (
mode == ControlMode::ExtendedPosition &&
(force_set || control_mode_ != ControlMode::ExtendedPosition)) {
bool torque_enabled = torque_enabled_;
if (torque_enabled) {
enable_torque(false);
}

for (uint i = 0; i < joint_ids_.size(); ++i) {
if (!dynamixel_workbench_.setExtendedPositionControlMode(joint_ids_[i], &log)) {
RCLCPP_FATAL(rclcpp::get_logger(kDynamixelHardware), "%s", log);
return return_type::ERROR;
}
}
RCLCPP_INFO(rclcpp::get_logger(kDynamixelHardware), "Extended Position control");
if (control_mode_ != ControlMode::ExtendedPosition) {
mode_changed_ = true;
control_mode_ = ControlMode::ExtendedPosition;
}

if (torque_enabled) {
enable_torque(true);
}
return return_type::OK;
}

if (
control_mode_ != ControlMode::Velocity && control_mode_ != ControlMode::Position &&
control_mode_ != ControlMode::ExtendedPosition) {
RCLCPP_FATAL(
rclcpp::get_logger(kDynamixelHardware), "Only position/velocity control are implemented");
return return_type::ERROR;
Expand Down