core: Add changesets releases #395
Conversation
🦋 Changeset detectedLatest commit: 986f3b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.changeset/honest-elephants-care.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@ebay/ui-core-react": patch | |||
There was a problem hiding this comment.
Seems more like a feature, so Id put it in a minor version
There was a problem hiding this comment.
Technically I don't need a version for this, it was just to test the action
There was a problem hiding this comment.
I will remove this changeset. It is a core change that doesn't need a version update
| "prerelease:end": "changeset pre exit || :", | ||
| "prerelease:start": "changeset pre enter next || :", | ||
| "prepare": "node scripts/husky-install || node ../scripts/husky-install", | ||
| "version": "yarn update-icons && git add -A src && changeset version" |
There was a problem hiding this comment.
One issue we found was that when doing a release, the package-lock version does not get changed. By doing npm i --package-lock-only this will regenerate the package-lock version. That said, I don't know if theres an equivalent or similar problem for yarn.
There was a problem hiding this comment.
Does changeset changes the version of the lock file?
There was a problem hiding this comment.
Ah, I see the issue now, although yarn.lock doesn't have the version of the package, only package-lock has it.
pushandpractions