Skip to content

Commit

Permalink
Merge pull request #452 from LluisArevalo/master
Browse files Browse the repository at this point in the history
Image Upload to S3 - ContentType not set
  • Loading branch information
jackycute authored May 8, 2017
2 parents 5343a61 + 6bf32af commit 90631df
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
6 changes: 6 additions & 0 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ var i18n = require('i18n')
var flash = require('connect-flash')
var validator = require('validator')

// utils
var getImageMimeType = require('./lib/utils.js').getImageMimeType

// core
var config = require('./lib/config.js')
var logger = require('./lib/logger.js')
Expand Down Expand Up @@ -548,6 +551,9 @@ app.post('/uploadimage', function (req, res) {
Body: buffer
}

var mimeType = getImageMimeType(files.image.path)
if (mimeType) { params.ContentType = mimeType }

s3.putObject(params, function (err, data) {
if (err) {
logger.error(err)
Expand Down
20 changes: 20 additions & 0 deletions lib/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,23 @@
exports.isSQLite = function isSQLite (sequelize) {
return sequelize.options.dialect === 'sqlite'
}

exports.getImageMimeType = function getImageMimeType (imagePath) {
var fileExtension = /[^.]+$/.exec(imagePath)

switch (fileExtension[0]) {
case 'bmp':
return 'image/bmp'
case 'gif':
return 'image/gif'
case 'jpg':
case 'jpeg':
return 'image/jpeg'
case 'png':
return 'image/png'
case 'tiff':
return 'image/tiff'
default:
return undefined
}
}

0 comments on commit 90631df

Please sign in to comment.