Further improvement of error handling for LZString

This does some more in depth check on the error message and minimizes the log noise that is caused by LZString. Signed-off-by: Sheogorath <[email protected]>
eceusc · Jul 27, 2018 · db5b86d · db5b86d
1 parent 1f85017
commit db5b86d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/history.js b/lib/history.js
@@ -47,7 +47,11 @@ function getHistory (userid, callback) {
           }
         } catch (err) {
           // most error here comes from LZString, ignore
-          logger.error(err)
+          if (err.message === 'Cannot read property \'charAt\' of undefined') {
+            logger.warning('Looks like we can not decode "' + history[i].id + '" with LZString. Can be ignored.')
+          } else {
+            logger.error(err)
+          }
         }
       }
       history = parseHistoryToObject(history)

diff --git a/lib/models/note.js b/lib/models/note.js
@@ -227,7 +227,11 @@ module.exports = function (sequelize, DataTypes) {
               var id = LZString.decompressFromBase64(noteId)
               if (id && Note.checkNoteIdValid(id)) { return callback(null, id) } else { return _callback(null, null) }
             } catch (err) {
-              logger.error(err)
+              if (err.message === 'Cannot read property \'charAt\' of undefined') {
+                logger.warning('Looks like we can not decode "' + noteId + '" with LZString. Can be ignored.')
+              } else {
+                logger.error(err)
+              }
               return _callback(null, null)
             }
           },