Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adjust OSGiWeavingAdaptorTest to upstream AspectJ change
See eclipse-aspectj/aspectj@8c88314. Relates to #57.
- Loading branch information
84c7931
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kriegaex commenting here directly (I don't see the issue or PR to which this commit belongs.
I am fine with the change. The important line with respect to the fix addressed in this test case is
ajdt/org.eclipse.equinox.weaving.aspectj/src/org/eclipse/equinox/weaving/aspectj/loadtime/OSGiWeavingAdaptor.java
Line 176 in 84c7931
which makes sure that we do not store the woven bytes under a wrong name (which is derived from the map entry's key) in the cache. As long as that remains true, I don't see a problem with upstream changes.
Just a tiny nitpicky issue: Line 84
ajdt/org.eclipse.equinox.weaving.aspectj.tests/src/org/eclipse/equinox/weaving/aspectj/tests/OSGiWeavingAdaptorTest.java
Line 84 in 84c7931
still mentions four expected entries, but these are now 5. Maybe just remove the concrete number there to not cause any followup confusion.
84c7931
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the comment in 56c2333, thanks for your feedback.