[566621] Disable visual refresh of anchorages while attaching feedbac…

…k and handle parts.
eclipse-gef · Sep 2, 2020 · c34de30 · c34de30
1 parent b51ccce
commit c34de30
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/org.eclipse.gef.mvc.fx/src/org/eclipse/gef/mvc/fx/behaviors/AbstractBehavior.java b/org.eclipse.gef.mvc.fx/src/org/eclipse/gef/mvc/fx/behaviors/AbstractBehavior.java
@@ -88,7 +88,11 @@ protected void addAnchoreds(
 			targets.iterator().next().getRoot().addChildren(anchoreds);
 			for (IVisualPart<? extends Node> anchored : anchoreds) {
 				for (IVisualPart<? extends Node> anchorage : targets) {
+					// XXX: When adding feedback and handles, the anchorage
+					// should not need to refresh its visuals
+					anchorage.setRefreshVisual(false);
 					anchored.attachToAnchorage(anchorage);
+					anchorage.setRefreshVisual(true);
 				}
 			}
 		}
@@ -116,7 +120,11 @@ protected void addAnchoreds(
 					insertionIndex);
 			for (IVisualPart<? extends Node> anchored : anchoreds) {
 				for (IVisualPart<? extends Node> anchorage : targets) {
+					// XXX: When adding feedback and handles, the anchorage
+					// should not need to refresh its visuals
+					anchorage.setRefreshVisual(false);
 					anchored.attachToAnchorage(anchorage);
+					anchorage.setRefreshVisual(true);
 				}
 			}
 		}
@@ -561,7 +569,11 @@ protected void removeAnchoreds(
 		if (anchoreds != null && !anchoreds.isEmpty()) {
 			for (IVisualPart<? extends Node> anchored : anchoreds) {
 				for (IVisualPart<? extends Node> anchorage : targets) {
+					// XXX: When removing feedback and handles, the anchorage
+					// should not need to refresh its visuals
+					anchorage.setRefreshVisual(false);
 					anchored.detachFromAnchorage(anchorage);
+					anchorage.setRefreshVisual(true);
 				}
 			}
 			anchoreds.iterator().next().getRoot().removeChildren(anchoreds);