Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#Issue #565 - initial creation of intersection type #2702

Merged
merged 17 commits into from
Aug 20, 2024
Merged

#Issue #565 - initial creation of intersection type #2702

merged 17 commits into from
Aug 20, 2024

Conversation

kamilkrzywanski
Copy link
Contributor

@kamilkrzywanski kamilkrzywanski commented Jul 10, 2024 •
edited
Loading

What it does

fixes issue #565

Author checklist

@kamilkrzywanski
Copy link
Contributor Author

@jarthana @mpalat Can you look at it?

@mpalat
Copy link
Contributor

mpalat commented Jul 25, 2024

@jarthana @mpalat Can you look at it?

@jarthana - since it's APT will prefer you to have a look

@kamilkrzywanski
Merge branch 'master' of https://github.com/kamilkrzywanski/eclipse.j…
92456be 
…dt.core into issue_#565

# Conflicts:
#	org.eclipse.jdt.apt.pluggable.tests/META-INF/MANIFEST.MF
@kamilkrzywanski
Copy link
Contributor Author

@jarthana can you review this change?

@jarthana jarthana self-requested a review August 19, 2024 09:06
jarthana
jarthana requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@jarthana jarthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the code changes themselves acceptable. But the bundle versions are not required and tests need some changes.

...ests/src/org/eclipse/jdt/apt/pluggable/tests/processors/buildertester/Issue565Processor.java Outdated Show resolved Hide resolved
...ests/src/org/eclipse/jdt/apt/pluggable/tests/processors/buildertester/Issue565Processor.java Outdated Show resolved Hide resolved
...ests/src/org/eclipse/jdt/apt/pluggable/tests/processors/buildertester/Issue565Processor.java Show resolved Hide resolved
org.eclipse.jdt.core.compiler.batch/pom.xml Outdated Show resolved Hide resolved
org.eclipse.jdt.core.compiler.batch/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
org.eclipse.jdt.core/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
org.eclipse.jdt.core/pom.xml Outdated Show resolved Hide resolved
org.eclipse.jdt.apt.pluggable.core/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
org.eclipse.jdt.apt.pluggable.tests/META-INF/MANIFEST.MF Outdated Show resolved Hide resolved
@jarthana jarthana added this to the 4.33 RC1 milestone Aug 19, 2024
@jarthana
Copy link
Member

@kamilkrzywanski Sorry I missed this one out. If you can address the comments, we can still include this in RC1.

@jarthana jarthana merged commit 430761c into eclipse-jdt:master Aug 20, 2024
4 of 7 checks passed
@kamilkrzywanski kamilkrzywanski deleted the issue_#565 branch August 20, 2024 08:29
@stephan-herrmann stephan-herrmann mentioned this pull request Sep 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarthana jarthana jarthana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.33 RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@kamilkrzywanski @mpalat @jarthana