Support for Primitives in Detail Formatter #586
+564
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SougandhS
force-pushed
the
DetalFormatter_for_Primitives_and_Arrays
branch
from
5fe49cd to
e42dd75
Compare
|
Hi @jukzi , could u pls check this when you have time. |
SougandhS
changed the title
jukzi
reviewed
Jan 9, 2025
| @@ -307,14 +325,13 @@ private void selectType() { | |||
| SelectionDialog dialog= null; | |||
| try { | |||
| dialog= JavaUI.createTypeDialog(shell, PlatformUI.getWorkbench().getProgressService(), | |||
| SearchEngine.createWorkspaceScope(), IJavaElementSearchConstants.CONSIDER_ALL_TYPES, false, fTypeNameText.getText()); | |||
| SearchEngine.createWorkspaceScope(), IJavaElementSearchConstants.CONSIDER_ALL_TYPES, false, fTypeNameText.getText()); | |||
There was a problem hiding this comment.
looks like unintentional space change
There was a problem hiding this comment.
Auto format issue - will resolve it
jukzi
reviewed
Jan 9, 2025
| @@ -254,6 +254,8 @@ DetailFormatterDialog_Add_Detail_Formatter_2=Add Detail Formatter | |||
| DetailFormatterDialog_Associated_code_must_not_be_empty_3=Detail formatter code snippet must not be empty | |||
| DetailFormatterDialog_Detail_formatter__code_snippet__1=Detail formatter &code snippet: | |||
| DetailFormatterDialog_17=Detail formatter &code snippet ({0} for code assist): | |||
| DetailFormatterPrimitiveSelect=Select Primitives | |||
There was a problem hiding this comment.
maybe the noun should be low caps. i am not sure
jukzi
reviewed
Jan 9, 2025
| */ | ||
| @SuppressWarnings("nls") | ||
| private List<String> getPrimitiveTypes() { | ||
| return List.of("int", "long", "short", "float", "double", "boolean", "char", "byte", "int[]", "long[]", "short[]", "float[]", "double[]", "boolean[]", "char[]", "byte[]"); |
There was a problem hiding this comment.
does it work with arrays of multiple dimensions? for example char[][]
There was a problem hiding this comment.
Yes it works.. added test case for that too
jukzi
reviewed
Jan 9, 2025
| @@ -55,6 +56,10 @@ public interface IRuntimeContext { | |||
| */ | |||
| IJavaObject getThis() throws CoreException; | |||
|
|
|||
| default IJavaPrimitiveValue getThisPrimitive() { | |||
jukzi
reviewed
Jan 9, 2025
| @@ -745,22 +745,12 @@ | |||
| id="org.eclipse.jdt.debug.ui.FilteredJavaVariableActions"> | |||
| <visibility> | |||
| <and> | |||
| <objectState | |||
There was a problem hiding this comment.
are this lines removed intantionally?
There was a problem hiding this comment.
Yes.. to get detail formatter option in variables view
|
looks like a cool feature. i would love to see char[] and char[][] fromatted by default |
SougandhS
force-pushed
the
DetalFormatter_for_Primitives_and_Arrays
branch
2 times, most recently
from
e4b558b to
f06ef02
Compare
|
|
i actually tried this PR for char[][] -> what am i am doing wrong? |
jukzi
requested changes
Jan 9, 2025
try this - java.util.Arrays.deepToString(this) 
|
but i want a custom format to just concat a chars. |
This commit provides support for Primitive types and Primitive arrays in Detail Formatter for variables view. Fixes : eclipse-jdt#268
SougandhS
force-pushed
the
DetalFormatter_for_Primitives_and_Arrays
branch
from
f06ef02 to
55c37bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for primitive types (int,float,char etc) for detail formatter
Fixes : #268
What it does
How to test
Author checklist