Fix some more error ids #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
dom-with-javac-more-problemids
branch
from
183d2c7 to
f006fae
Compare
akurtakov
reviewed
Sep 4, 2024
| case "compiler.warn.unchecked.meth.invocation.applied" -> IProblem.UnsafeTypeConversion; | ||
| case "compiler.err.encl.class.required" -> IProblem.MissingEnclosingInstanceForConstructorCall; | ||
| case "compiler.err.operator.cant.be.applied" -> IProblem.InvalidOperator; | ||
| case "compiler.warn.try.resource.not.referenced" -> 0; // ECJ doesn't do this |
There was a problem hiding this comment.
This came into discussion today. Should we "ignore" like done here or we should find a way to report such warnings as this is clear benefit from using javac? See #795
There was a problem hiding this comment.
I'll take Fred's suggestion of finding the closest category of error and using that as the problem id. As well, I'll comment that these are not in ECJ.
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
dom-with-javac-more-problemids
branch
from
f006fae to
ffb1d83
Compare
|
There two new failures as a result of this PR. One of the new failures is a flaky test, and another is caused because there is an error where ECJ doesn't generate one. I will merge this as is, because from my understanding this is okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.