Change release flow

[erikbosch]

This is a proposal to change the release handling somewhat

Today

• Create a tag and push to remote
• Trigger workflow on the tag and mention wanted version (e.g. 1.2.3)

If you trigger on branch you will get a faulty tag proposal in draft release that you must correct, tag will be created when release is published

After this PR

• Create a tag and push to remote
• Creation of release is started automatically

If you run the workflow on a branch you will get a release named after the branch, which you likely do not want

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.49%. Comparing base (f57c6fd) to head (f290251).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   59.61%   59.49%   -0.13%     
==========================================
  Files          33       33              
  Lines       16071    16071              
==========================================
- Hits         9581     9561      -20     
- Misses       6490     6510      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lukasmittag]

Suggested change

	workflow_dispatch: # select tag when creating
	on:
	release:
	types: [published]

use this instead?

[erikbosch]

What would be the intended use case? We have an action further down in the script ( softprops/action-gh-release@v2) to create a release, and that becomes quite useless if we already have created a release.

And adding on:release is a bit superfluous. If you create a new release, and the tag does not exist since before a new tag will be created and that will anyway trigger this workflow.

I am actually considering if we should remove workflow_dispatch - I do not see that many use-cases for it, except possibly if you have yanked a release and want to rebuild a new release for the same tag.

[SebastianSchildt]

Looks useful. I think the risk is sort of low, it creates draft releases, that can likely be deleted via GH WebUI if really needed.