Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-tls build for databroker #118

Merged

Conversation

AkhilTThomas
Copy link
Contributor

@AkhilTThomas AkhilTThomas commented Dec 11, 2024

This PR fixes the broken build when building kuksa-databroker with --no-default-features flag.
Additionally i have also enforced that tls feature flag for kuksa and common are not used in no-default-feature mode.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.56%. Comparing base (2159d18) to head (549d70e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/grpc/server.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   59.49%   59.56%   +0.06%     
==========================================
  Files          33       33              
  Lines       16070    16071       +1     
==========================================
+ Hits         9561     9572      +11     
+ Misses       6509     6499      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AkhilTThomas AkhilTThomas force-pushed the fix-broke-no-default-feat branch from 65fc11f to 4bc10cb Compare December 11, 2024 08:43
@AkhilTThomas AkhilTThomas changed the title move ServerTLS under feature flag Fix no-tls build for databroker Dec 11, 2024
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I verified TLS connection is still in the default builds from CI and works.

@SebastianSchildt SebastianSchildt force-pushed the fix-broke-no-default-feat branch from 0cf937c to 549d70e Compare December 12, 2024 10:09
@AkhilTThomas
Copy link
Contributor Author

AkhilTThomas commented Dec 12, 2024

Looking good. I verified TLS connection is still in the default builds from CI and works.

It would be good if -no-default-features build is added to CI to ensure that this is caught sooner

@SebastianSchildt
Copy link
Contributor

Agree, I created a seperate issue for that (PRs welcome of course :D ) to not blocking the immediate fix

@SebastianSchildt SebastianSchildt merged commit f57c6fd into eclipse-kuksa:main Dec 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants