-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no-tls build for databroker #118
Fix no-tls build for databroker #118
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 59.49% 59.56% +0.06%
==========================================
Files 33 33
Lines 16070 16071 +1
==========================================
+ Hits 9561 9572 +11
+ Misses 6509 6499 -10 ☔ View full report in Codecov by Sentry. |
65fc11f
to
4bc10cb
Compare
ServerTLS
under feature flagThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I verified TLS connection is still in the default builds from CI and works.
0cf937c
to
549d70e
Compare
It would be good if |
Agree, I created a seperate issue for that (PRs welcome of course :D ) to not blocking the immediate fix |
This PR fixes the broken build when building
kuksa-databroker
with--no-default-features
flag.Additionally i have also enforced that
tls
feature flag forkuksa
andcommon
are not used inno-default-feature
mode.