PR feedback

- Ensure column-index is 1-based to avoid error
- Make properties of optional options also optional
- Mark test case as failing

packages/langium/src/parser/indentation-aware.ts

@@ -315,7 +315,7 @@ export class IndentationAwareTokenBuilder<Terminals extends string = string, Key
                 offset,
                 length: match?.[0]?.length ?? 0,
                 line: this.getLineNumber(text, offset),
-                column: 0
+                column: 1
             });
             return null;
         }

packages/langium/src/parser/lexer.ts

@@ -28,7 +28,7 @@ export interface LexerResult {
 export type TokenizeMode = 'full' | 'partial';
 
 export interface TokenizeOptions {
-    mode: TokenizeMode;
+    mode?: TokenizeMode;
 }
 
 export const DEFAULT_TOKENIZE_OPTIONS: TokenizeOptions = { mode: 'full' };

packages/langium/test/parser/indentation-aware.test.ts

@@ -401,7 +401,7 @@ describe('IndentationAware parsing', () => {
         expect(return2.value).toBe(true);
     });
 
-    test('should offer correct auto-completion parsing', async () => {
+    test.fails('should offer correct auto-completion parsing', async () => {
         const text = expandToString`
         <|>if true:
             <|>return true
@@ -415,6 +415,7 @@ describe('IndentationAware parsing', () => {
         const services = await createIndentationAwareServices(sampleGrammar);
         const completion = expectCompletion(services);
         await completion({ text, index: 0, expectedItems: ['if', 'return'] });
+        // PR 1669: the lines below currently fail as the completion provider may wrongly assumes that all whitespace tokens are hidden
         await completion({ text, index: 1, expectedItems: ['if', 'return'] });
         await completion({ text, index: 2, expectedItems: ['else'] });
         await completion({ text, index: 3, expectedItems: ['if', 'return'] });