Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run npm audit fix #1789

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Run npm audit fix #1789

merged 1 commit into from
Jan 14, 2025

Conversation

aabounegm
Copy link
Member

@aabounegm aabounegm commented Jan 14, 2025

This fixes the security vulnerabilities reported by Dependabot and npm
https://github.com/eclipse-langium/langium/security/dependabot

This fixes the security vulnerabilities reported by Dependabot and npm
https://github.com/eclipse-langium/langium/security/dependabot
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aabounegm. I believe these security issues all come from our dev dependencies, but it's good practice to update them anyway.

@msujew msujew merged commit ce47f6e into main Jan 14, 2025
5 checks passed
@msujew msujew deleted the security-vulnerabilities branch January 14, 2025 10:23
@aabounegm
Copy link
Member Author

To be honest, I was just getting annoyed with the weekly emails from GitHub 😁

@cdietrich
Copy link
Contributor

wonder if something needs to be enabled here for dependabot to open prs.

@aabounegm
Copy link
Member Author

@cdietrich Yes, we just need to enable this option under https://github.com/eclipse-langium/langium/settings/security_analysis:

Screenshot 2025-01-14 at 12 47 14 PM

They were on by the default in other projects I worked on, so I assumed someone disabled them on purpose (or maybe the GitHub default changed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants