Implemented configurable delay for feedback messages (Downloading and Installing) #49
Conversation
OleksandrChaika
changed the title
src/Context.h
Outdated
| @@ -62,6 +62,7 @@ namespace sua { | |||
| std::string caFilepath = SUA_DEFAULT_CA_FILEPATH; | |||
| bool downloadMode = true; | |||
| bool fallbackMode = false; | |||
| int messageDelay = SUA_DEFAULT_MESSAGE_DELAY; | |||
There was a problem hiding this comment.
You should add the unit as comment - [s] (also in Defaults.cpp)
There was a problem hiding this comment.
The name "delay" is misleading. It means that something will happen later. But here it's more a suppression/rejection interval/duration/period.
There was a problem hiding this comment.
You should add the unit as comment - [s] (also in Defaults.cpp)
Fixed, both
src/FSM/States/Downloading.h
Outdated
| @@ -32,6 +32,9 @@ namespace sua { | |||
| void onEnter(Context& ctx) override; | |||
|
|
|||
| FotaEvent body(Context& ctx) override; | |||
|
|
|||
| private: | |||
| long long _last_update = 0; | |||
There was a problem hiding this comment.
better rename: _time_last_update; // [s]
or CamelCase?
src/FSM/States/Installing.h
Outdated
| @@ -32,6 +32,9 @@ namespace sua { | |||
| void onEnter(Context& ctx) override; | |||
|
|
|||
| FotaEvent body(Context& ctx) override; | |||
|
|
|||
| private: | |||
| long long _last_update = 0; | |||
There was a problem hiding this comment.
name: ref. in Downloading
| if(now_in_seconds - _last_update > ctx.messageDelay) { | ||
| send(ctx, IMqttProcessor::TOPIC_FEEDBACK, MqttMessage::Downloading); | ||
| _last_update = now_in_seconds; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is it ok, that the final event could not always result to a message? Perhaps downloadProgressPercentage==100 is an important value that triggers something on server side so that at least the last event should always be sent.
Same mind for installation
| @@ -22,6 +22,8 @@ | |||
| #include "FotaEvent.h" | |||
| #include "Logger.h" | |||
|
|
|||
| #include <chrono> | |||
There was a problem hiding this comment.
also to be included in Installing.cpp?
src/FSM/States/Downloading.cpp
Outdated
| Logger::info("Download progress: {}%", ctx.desiredState.downloadProgressPercentage); | ||
| send(ctx, IMqttProcessor::TOPIC_FEEDBACK, MqttMessage::Downloading); | ||
|
|
||
| if(now_in_seconds - _last_update > ctx.messageDelay) { |
There was a problem hiding this comment.
Shoud be operation >=:
now - last >= 5,
e.g. n s + 5 s = (n+5) s ==> send msg
(n+5) - n >= 5
same in Installating
OleksandrChaika
force-pushed
the
feature/interval_for_feedback
branch
from
65dd60f to
0742ff0
Compare
… Installing)