Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build embedd broker as shared library #3057

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NorbertHeusser
Copy link
Contributor

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.62%. Comparing base (3c1a8c1) to head (9886279).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3057      +/-   ##
===========================================
+ Coverage    81.35%   81.62%   +0.26%     
===========================================
  Files          191      196       +5     
  Lines        31780    32163     +383     
===========================================
+ Hits         25855    26253     +398     
+ Misses        5925     5910      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ralight ralight force-pushed the develop branch 3 times, most recently from b7e2d3d to e715b04 Compare October 29, 2024 10:40
@NorbertHeusser NorbertHeusser force-pushed the embedded-broker branch 2 times, most recently from dcb64da to d32e8bc Compare November 15, 2024 14:10
@RimonGazi
Copy link

Could you kindly provide an update on when this feature is expected to be merged and available?

@NorbertHeusser
Copy link
Contributor Author

NorbertHeusser commented Jan 7, 2025

Right now some builds are failing and I have to rebase the branch to the latest development branch before it maybe merged.
Will take a look, if I can find some time in the next days to update this PR.

As the PR is targeting the develop branch it will get into official broker packages anyway some time in the future. As I needed the change in one of my private projects I back ported the changes to the current 2.0.20 version. If you need a version like this you may pick the source from my fork: https://github.com/NorbertHeusser/mosquitto/releases/tag/v2.0.20-embedd-broker.

If there is an interest into this change in general I may try to make a different PR targeting the current master branch. But it's not my decision, if this change is considered a "fix" and maybe merged into the master branch.

@NorbertHeusser
Copy link
Contributor Author

Updated the PR to the latest develop branch. Looks like the build issues are in the develop branch and not related to this change.

@RimonGazi
Copy link

Thanks for the update, @NorbertHeusser! I really appreciate the effort you've put into rebasing this to the latest develop branch. It's good to know that the build issues are related to the develop branch and not your changes.

Also, thank you for providing the link to the v2.0.20-embedded-broker release — that will definitely be helpful for anyone needing it before the feature is merged.

Looking forward to seeing this feature merged once the issues are resolved. Thanks again for your hard work and for keeping us updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants