-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to build embedd broker as shared library #3057
base: develop
Are you sure you want to change the base?
Add option to build embedd broker as shared library #3057
Conversation
63ecc30
to
9886279
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3057 +/- ##
===========================================
+ Coverage 81.35% 81.62% +0.26%
===========================================
Files 191 196 +5
Lines 31780 32163 +383
===========================================
+ Hits 25855 26253 +398
+ Misses 5925 5910 -15 ☔ View full report in Codecov by Sentry. |
b7e2d3d
to
e715b04
Compare
dcb64da
to
d32e8bc
Compare
Could you kindly provide an update on when this feature is expected to be merged and available? |
Right now some builds are failing and I have to rebase the branch to the latest development branch before it maybe merged. As the PR is targeting the develop branch it will get into official broker packages anyway some time in the future. As I needed the change in one of my private projects I back ported the changes to the current 2.0.20 version. If you need a version like this you may pick the source from my fork: https://github.com/NorbertHeusser/mosquitto/releases/tag/v2.0.20-embedd-broker. If there is an interest into this change in general I may try to make a different PR targeting the current master branch. But it's not my decision, if this change is considered a "fix" and maybe merged into the master branch. |
Signed-off-by: Norbert Heusser <[email protected]>
d32e8bc
to
cbaa705
Compare
Updated the PR to the latest develop branch. Looks like the build issues are in the develop branch and not related to this change. |
Thanks for the update, @NorbertHeusser! I really appreciate the effort you've put into rebasing this to the latest develop branch. It's good to know that the build issues are related to the develop branch and not your changes. Also, thank you for providing the link to the v2.0.20-embedded-broker release — that will definitely be helpful for anyone needing it before the feature is merged. Looking forward to seeing this feature merged once the issues are resolved. Thanks again for your hard work and for keeping us updated! |
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make test
with your changes locally?