EDGAR support using custom bridge name in managed mode #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voelkera
force-pushed
the
56
branch
3 times, most recently
from
af159c3 to
ff11860
Compare
mbfm
requested changes
Apr 23, 2024
opendut-edgar/src/setup/tasks/network_interface/create_interface_group.rs
Outdated
Show resolved
Hide resolved
opendut-lea/src/peers/configurator/tabs/network/bridge_name_input.rs
Outdated
Show resolved
Hide resolved
voelkera
force-pushed
the
56
branch
3 times, most recently
from
2e8a0f9 to
0a237b1
Compare
mbfm
reviewed
Apr 29, 2024
opendut-carl/src/actions/peers.rs
Outdated
Comment on lines
81
to
94
| let peer_network_configuration = match peer_descriptor.clone().network.bridge_name { | ||
| Some(bridge_name) => { | ||
| PeerNetworkConfiguration { | ||
| bridge_name, | ||
| } | ||
| } | ||
| None => { PeerNetworkConfiguration::default() } | ||
| }; | ||
|
|
There was a problem hiding this comment.
Load this from the carl.toml, e.g.:
[peer]
ethernet.bridge.name.default = "br-opendut"
You will need to pass the loaded settings-object from the lib.rs into the action somehow and then grab the value from there.
mbfm
reviewed
Apr 29, 2024
Comment on lines
18
to
23
| impl Default for PeerNetworkConfiguration { | ||
| fn default() -> Self { | ||
| Self { | ||
| bridge_name: NetworkInterfaceName::try_from("br-opendut").unwrap(), | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove this default (should be loaded from carl.toml).
mbfm
reviewed
Apr 29, 2024
Comment on lines
27
to
28
| #[table(title = "BridgeName")] | ||
| bridge_name: String, |
There was a problem hiding this comment.
Remove these two lines. The user very likely does not care about the bridge_name when listing or describing peers.
Suggested change
| #[table(title = "BridgeName")] | |
| bridge_name: String, |
mbfm
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #56