Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS processing crashes when Pattern matching is used in a switch statement #1553

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

FlorianKroiss
Copy link
Contributor

  • Use getJLSLatest instead of deprecated JLS4 constant to use latest AST Parser

…ment eclipse-pde#1440

+ Use getJLSLatest instead of deprecated JLS4 constant to use latest AST Parser
@FlorianKroiss FlorianKroiss changed the title DS processing crashes when Pattern matching is used in a switch statement #1440 DS processing crashes when Pattern matching is used in a switch statement Jan 10, 2025
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 603b6f971996c22cb004d5620768f783988e9aa6 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 10 Jan 2025 16:40:34 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
index dec0baad2a..00bf98a9ce 100644
--- a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.ds.annotations;singleton:=true
-Bundle-Version: 1.3.500.qualifier
+Bundle-Version: 1.3.600.qualifier
 Bundle-Activator: org.eclipse.pde.ds.internal.annotations.Activator
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.ui;bundle-version="[3.105.0,4.0.0)",
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   285 files     285 suites   53m 10s ⏱️
 3 586 tests  3 510 ✅  76 💤 0 ❌
10 950 runs  10 719 ✅ 231 💤 0 ❌

Results for commit 6f9d404.

Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me there is no need to use "old" parsers here.

@laeubi
Copy link
Contributor

laeubi commented Jan 10, 2025

@FlorianKroiss thanks for this fix, you might want to add a testcase here so we do not run into such issue in the future.

@laeubi laeubi merged commit 0c0b31a into eclipse-pde:master Jan 10, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants