Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest): create new endpoint for import OSADL information in admin. #2114

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(rest): create new endpoint for import OSADL information in admin. #2114

merged 1 commit into from
Oct 18, 2023

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Aug 31, 2023 •
edited
Loading

You will import SPDX information in admin license.

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: #2113

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

1: login sw360 with admin user
2: /resource/api/licenses/import/OSADL

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@nikkuma7 nikkuma7 force-pushed the fix/AdminImportOSADLInfo branch from 97213a6 to 4e8b2ba Compare August 31, 2023 06:17
@KoukiHama KoukiHama requested review from tienlee and hoangnt2 August 31, 2023 07:06
hoangnt2
hoangnt2 requested changes Sep 5, 2023
View reviewed changes
rest/resource-server/src/docs/asciidoc/licenses.adoc Outdated

[[import-osdal-info]]
==== Import osdal information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo osdal -> OSADL (same with other places)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/LicenseSpecTest.java Outdated Show resolved Hide resolved
@ag4ums ag4ums added has merge conflicts New-UI Level for the API and UI level changes for the new-ui labels Sep 5, 2023
@nikkuma7 nikkuma7 force-pushed the fix/AdminImportOSADLInfo branch 2 times, most recently from 52c6cff to 49ac7c7 Compare September 6, 2023 08:18
@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed has merge conflicts labels Sep 6, 2023
@ag4ums ag4ums added the REST label Sep 6, 2023
@hoangnt2
Copy link
Contributor

hoangnt2 commented Sep 6, 2023

Code look good

@keerthi-bl
Copy link
Contributor

Please add proper response. Now getting just empty message box.

image

@nikkuma7 nikkuma7 force-pushed the fix/AdminImportOSADLInfo branch 3 times, most recently from 30bd425 to d320027 Compare October 5, 2023 06:29
@keerthi-bl
Copy link
Contributor

Testing completed and working as expected.

image

@ag4ums ag4ums added ready ready to merge has merge conflicts and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Oct 6, 2023
@nikkuma7 nikkuma7 force-pushed the fix/AdminImportOSADLInfo branch from d320027 to eb7efb3 Compare October 12, 2023 05:52
@ag4ums ag4ums merged commit d52da37 into eclipse-sw360:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnt2 hoangnt2 hoangnt2 approved these changes

@tienlee tienlee Awaiting requested review from tienlee

Assignees

@KoukiHama KoukiHama

Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikkuma7 @hoangnt2 @keerthi-bl @ag4ums @KoukiHama