Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest) : Adding or Modifying fields to project summaryadministration API #2145

Merged

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

No

Issue: #2135

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

Can be tested using Rest client - Postman.

Sample URL : http://localhost:8080/resource/api/projects/16f6d03ada424dea81c86fabdab3ee35/summaryAdministration

Sample response :

{
"name": "Product Release 1",
"description": "Product Release 1",
"version": "1.0",
"domain": "Application Software",
"createdOn": "2023-01-18",
"businessUnit": "DEPARTMENT",
"state": "ACTIVE",
"tag": "product",
"clearingState": "OPEN",
"roles": {},
"ownerAccountingUnit": "",
"ownerGroup": "",
"ownerCountry": "",
"preevaluationDeadline": "",
"systemTestStart": "",
"systemTestEnd": "",
"deliveryStart": "",
"phaseOutSince": "",
"enableSvm": false,
"externalIds": {},
"additionalData": {},
"considerReleasesFromExternalList": false,
"enableVulnerabilitiesDisplay": false,
"clearingSummary": "",
"specialRisksOSS": "",
"generalRisks3rdParty": "",
"specialRisks3rdParty": "",
"deliveryChannels": "",
"remarksAdditionalRequirements": "",
"clearingRequestId": "CR-1",
"externalUrls": {},
"modifiedOn": "2023-01-31",
"projectType": "PRODUCT",
"visibility": "BUISNESSUNIT_AND_MODERATORS",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/projects/16f6d03ada424dea81c86fabdab3ee35"
}
},
"_embedded": {
"leadArchitect": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
},
"clearingTeam": {
"email": "Unknown",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/Unknown"
}
}
},
"securityResponsibles": [
{
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
}
],
"createdBy": {
"email": "[email protected]",
"deactivated": false,
"fullName": "Test Admin",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/3a678af8c1ce43daa883cd09dd49927e"
}
}
},
"licenseInfoHeaderText": "",
"modifiedBy": {
"email": "[email protected]",
"deactivated": false,
"fullName": "keerthi bl",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/7312f989631847e2951cb12a9387ad72"
}
}
},
"projectOwner": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
},
"projectResponsible": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
}
}
}

Have you implemented any additional tests?
No

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@nikkuma7
Copy link
Contributor

Test successful.
image

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST labels Oct 18, 2023
@rudra-superrr rudra-superrr self-assigned this Oct 23, 2023
@keerthi-bl keerthi-bl force-pushed the fix/AddorModifyFieldsInProjectAdminSummary branch 3 times, most recently from a392f7e to 84a5b4f Compare October 25, 2023 08:57
@rudra-superrr
Copy link
Contributor

Following errors found while testing:

  1. ProjectResponsible and securityResponsibles coming twice in response structure.
    image
    image
    image

  2. SecurityResponsibles field is empty.

  3. LicenseHeaderText is also empty.

@keerthi-bl
Copy link
Contributor Author

LicenseHeaderText will be taking as a different issue, since it will be captured based on groups it will be written as a separate API. The issue reference for the same will be :
https://code.siemens.com/sw360/sw360portal/-/issues/1376 (internal issue reference).

@keerthi-bl keerthi-bl force-pushed the fix/AddorModifyFieldsInProjectAdminSummary branch from 84a5b4f to 271e4bd Compare November 2, 2023 08:47
@keerthi-bl
Copy link
Contributor Author

Review comments addressed.

@keerthi-bl keerthi-bl force-pushed the fix/AddorModifyFieldsInProjectAdminSummary branch from 271e4bd to faddf60 Compare November 7, 2023 04:24
@keerthi-bl keerthi-bl force-pushed the fix/AddorModifyFieldsInProjectAdminSummary branch 2 times, most recently from cc6d6ce to e77a131 Compare November 15, 2023 07:48
@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Nov 15, 2023
@keerthi-bl keerthi-bl force-pushed the fix/AddorModifyFieldsInProjectAdminSummary branch from e77a131 to c805ff9 Compare November 17, 2023 08:50
@rudra-superrr
Copy link
Contributor

Code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge REST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants