-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest) : Adding or Modifying fields to project summaryadministration API #2145
Merged
ag4ums
merged 1 commit into
eclipse-sw360:main
from
siemens:fix/AddorModifyFieldsInProjectAdminSummary
Nov 20, 2023
Merged
feat(rest) : Adding or Modifying fields to project summaryadministration API #2145
ag4ums
merged 1 commit into
eclipse-sw360:main
from
siemens:fix/AddorModifyFieldsInProjectAdminSummary
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag4ums
added
needs code review
needs general test
This is general testing, meaning that there is no org specific issue to check for
REST
labels
Oct 18, 2023
...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ProjectSpecTest.java
Outdated
Show resolved
Hide resolved
...ce-server/src/main/java/org/eclipse/sw360/rest/resourceserver/project/ProjectController.java
Outdated
Show resolved
Hide resolved
keerthi-bl
force-pushed
the
fix/AddorModifyFieldsInProjectAdminSummary
branch
3 times, most recently
from
October 25, 2023 08:57
a392f7e
to
84a5b4f
Compare
LicenseHeaderText will be taking as a different issue, since it will be captured based on groups it will be written as a separate API. The issue reference for the same will be : |
keerthi-bl
force-pushed
the
fix/AddorModifyFieldsInProjectAdminSummary
branch
from
November 2, 2023 08:47
84a5b4f
to
271e4bd
Compare
Review comments addressed. |
keerthi-bl
force-pushed
the
fix/AddorModifyFieldsInProjectAdminSummary
branch
from
November 7, 2023 04:24
271e4bd
to
faddf60
Compare
keerthi-bl
force-pushed
the
fix/AddorModifyFieldsInProjectAdminSummary
branch
2 times, most recently
from
November 15, 2023 07:48
cc6d6ce
to
e77a131
Compare
rudra-superrr
removed
the
needs general test
This is general testing, meaning that there is no org specific issue to check for
label
Nov 15, 2023
…ion page Signed-off-by: Keerthi B L <[email protected]>
keerthi-bl
force-pushed
the
fix/AddorModifyFieldsInProjectAdminSummary
branch
from
November 17, 2023 08:50
e77a131
to
c805ff9
Compare
Code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No
Issue: #2135
Suggest Reviewer
How To Test?
Can be tested using Rest client - Postman.
Sample URL : http://localhost:8080/resource/api/projects/16f6d03ada424dea81c86fabdab3ee35/summaryAdministration
Sample response :
{
"name": "Product Release 1",
"description": "Product Release 1",
"version": "1.0",
"domain": "Application Software",
"createdOn": "2023-01-18",
"businessUnit": "DEPARTMENT",
"state": "ACTIVE",
"tag": "product",
"clearingState": "OPEN",
"roles": {},
"ownerAccountingUnit": "",
"ownerGroup": "",
"ownerCountry": "",
"preevaluationDeadline": "",
"systemTestStart": "",
"systemTestEnd": "",
"deliveryStart": "",
"phaseOutSince": "",
"enableSvm": false,
"externalIds": {},
"additionalData": {},
"considerReleasesFromExternalList": false,
"enableVulnerabilitiesDisplay": false,
"clearingSummary": "",
"specialRisksOSS": "",
"generalRisks3rdParty": "",
"specialRisks3rdParty": "",
"deliveryChannels": "",
"remarksAdditionalRequirements": "",
"clearingRequestId": "CR-1",
"externalUrls": {},
"modifiedOn": "2023-01-31",
"projectType": "PRODUCT",
"visibility": "BUISNESSUNIT_AND_MODERATORS",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/projects/16f6d03ada424dea81c86fabdab3ee35"
}
},
"_embedded": {
"leadArchitect": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
},
"clearingTeam": {
"email": "Unknown",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/Unknown"
}
}
},
"securityResponsibles": [
{
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
}
],
"createdBy": {
"email": "[email protected]",
"deactivated": false,
"fullName": "Test Admin",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/3a678af8c1ce43daa883cd09dd49927e"
}
}
},
"licenseInfoHeaderText": "",
"modifiedBy": {
"email": "[email protected]",
"deactivated": false,
"fullName": "keerthi bl",
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid/7312f989631847e2951cb12a9387ad72"
}
}
},
"projectOwner": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
},
"projectResponsible": {
"email": "",
"deactivated": false,
"_links": {
"self": {
"href": "http://localhost:8080/resource/api/users/byid"
}
}
}
}
}
Checklist
Must: