fix(rest) : create new endpoint for cleanup attachment. #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
5 times, most recently
from
2b03949 to
b6875c7
Compare
smrutis1
added
needs code review
needs general test
hoangnt2
reviewed
Nov 16, 2023
| @BasePathAwareController | ||
| @RequiredArgsConstructor(onConstructor = @__(@Autowired)) | ||
| public class AttachmentCleanUpController implements RepresentationModelProcessor<RepositoryLinksResource> { | ||
| public static final String ATTACHMENTCLEANUP_URL = "/attachmentCleanUp"; |
There was a problem hiding this comment.
ATTACHMENTCLEANUP_URL -> ATTACHMENT_CLEANUP_URL
| private final RestControllerHelper restControllerHelper; | ||
|
|
||
| @NonNull | ||
| private final Sw360AttachmentCleanUpService attachmentCleanupservive; |
There was a problem hiding this comment.
typo attachmentCleanupservive -> attachmentCleanUpService
There was a problem hiding this comment.
@nikkuma7 service not servive
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
b6875c7 to
07b347c
Compare
hoangnt2
requested changes
Dec 1, 2023
| private final RestControllerHelper restControllerHelper; | ||
|
|
||
| @NonNull | ||
| private final Sw360AttachmentCleanUpService attachmentCleanUpServive; |
There was a problem hiding this comment.
typo attachmentCleanUpServive -> attachmentCleanUpService
| public ResponseEntity<RequestSummary> cleanUpAttachment() throws TException { | ||
| User sw360User = restControllerHelper.getSw360UserFromAuthentication(); | ||
| RequestSummary requestSummary = attachmentCleanUpServive.cleanUpAttachments(sw360User); | ||
| return new ResponseEntity<>(requestSummary,HttpStatus.OK); |
There was a problem hiding this comment.
typo attachmentCleanUpServive -> attachmentCleanUpService
|
Test successfully |
hoangnt2
removed
the
needs general test
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
07b347c to
fcfa737
Compare
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
fcfa737 to
72d5bfa
Compare
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
72d5bfa to
1ad5029
Compare
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
1ad5029 to
5cf5471
Compare
|
Hi @hoangnt2 , Could you please review my code. And please let me know if you find any issue. |
|
@hoangnt2 is vacation now. He will restart to review from next week. |
|
Code look good to me |
|
@nikkuma7, please solve confict |
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
fix/CleanUpAttachment
branch
from
5cf5471 to
16475d7
Compare
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2172
Suggest Reviewer
How To Test?
1: Login with Admin user.
Sample URL : http://localhost:8080/resource/api/attachmentCleanUp/deleteAll
Checklist
Must: