Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (rest) : Rest API for component search by Lucene search #2201

Merged

Conversation

keerthi-bl
Copy link
Contributor

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: #2195

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

Sample URL and response as follows in the screenshot.

URL : http://localhost:8080/resource/api/components?name=comp&page=0&page_entries=20&luceneSearch=true&sort=name,desc

image

Have you implemented any additional tests?
No

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@KoukiHama KoukiHama self-assigned this Nov 17, 2023
@KoukiHama KoukiHama added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for REST labels Nov 17, 2023
@keerthi-bl keerthi-bl changed the title fix (rest) : rest API created for component search by Lucene search fix (rest) : Rest API for component search by Lucene search Nov 17, 2023
@hoangnt2
Copy link
Contributor

hoangnt2 commented Nov 17, 2023

Another thing, this snippet is unnecessary in lucene search case.

image

It also causes the bug that don't have enough entries on a page when we search by component type.
For example: I want a page with only 10 items. But when I search by Component Type some pages don't have enough entries.

I think the filter should be done before we create pagination result.
I will be very grateful to you if you can help me fix it

@keerthi-bl keerthi-bl force-pushed the fix/luceneSearchApiForComponents branch from 69af416 to 16531b4 Compare November 20, 2023 06:04
@keerthi-bl keerthi-bl force-pushed the fix/luceneSearchApiForComponents branch from 16531b4 to 02d84be Compare November 22, 2023 07:26
@hoangnt2
Copy link
Contributor

Change look good to me

@hoangnt2
Copy link
Contributor

hoangnt2 commented Dec 1, 2023

Testing successfully
test

@hoangnt2 hoangnt2 added ready ready to merge and removed needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 1, 2023
@ag4ums ag4ums merged commit 7b4e260 into eclipse-sw360:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge REST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants