Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): add OpenAPI docs for /vulnerabilities #2202

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Nov 17, 2023

Please provide a summary of your changes here.

  1. Add OpenAPI docs for /vulnerabilities endpoints.
  2. Replace deprecated exception HttpMessageNotReadableException with HttpClientErrorException.

Continuation of #2071

Suggest Reviewer

@heliocastro
@KoukiHama
@ag4ums

How To Test?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Note: To be merged after #2200

@GMishx GMishx added needs code review do not merge - нет! needs general test This is general testing, meaning that there is no org specific issue to check for labels Nov 17, 2023
@GMishx GMishx force-pushed the docs/api/openapi-vulnerabilities branch from a3cae67 to 1b43ff2 Compare November 30, 2023 08:42
@GMishx
Copy link
Member Author

GMishx commented Nov 30, 2023

Rebased @ag4ums

@GMishx GMishx removed their assignment Nov 30, 2023
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and working as expected

@ag4ums ag4ums added has merge conflicts ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 5, 2023
1. Add OpenAPI docs for /releases endpoints.
2. Add the missing AsciiDoc for getting releases by external ID.
3. Replace deprecated exception `HttpMessageNotReadableException` with
`HttpClientErrorException`.

Also, change the parameter in `searchByExternalIds` to accommodate the
change done in 2fdd5f4 (issue eclipse-sw360#2207).

Signed-off-by: Gaurav Mishra <[email protected]>
1. Add OpenAPI docs for the `/vulnerabilities` endpoints.
2. Replace deprecated exception `HttpMessageNotReadableException` with
`HttpClientErrorException`.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx force-pushed the docs/api/openapi-vulnerabilities branch from 1b43ff2 to 8b5428d Compare December 5, 2023 12:55
@GMishx
Copy link
Member Author

GMishx commented Dec 5, 2023

Rebased @ag4ums

@ag4ums ag4ums merged commit 714d446 into eclipse-sw360:main Dec 6, 2023
2 checks passed
@GMishx GMishx deleted the docs/api/openapi-vulnerabilities branch December 12, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants