fix tag

eclipse-velocitas · Jan 24, 2024 · 025bab7 · 025bab7
1 parent ed58860
commit 025bab7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Dockerfiles/cpp/.devcontainer/Dockerfile b/Dockerfiles/cpp/.devcontainer/Dockerfile
@@ -18,7 +18,7 @@
 
 FROM --platform=$BUILDPLATFORM ubuntu:22.04 as builder
 
-ARG SDK_TAG=v0.4.1
+ARG SDK_TAG
 
 RUN echo $SDK_TAG > /container/cpp/version.txt
 
@@ -62,6 +62,8 @@ RUN conan remove --builds --src --force '*'
 
 FROM --platform=$TARGETPLATFORM ubuntu:22.04 as final
 
+ARG SDK_TAG
+
 RUN apt-get --fix-missing update && apt-get upgrade -y && \
     apt-get install -y jq sudo curl wget git \
     # install cpp packages

diff --git a/Dockerfiles/cpp/.devcontainer/devcontainer.json b/Dockerfiles/cpp/.devcontainer/devcontainer.json
@@ -2,7 +2,10 @@
     "name": "Base Container",
     "build": {
         "dockerfile": "Dockerfile",
-        "context": "../../.."
+        "context": "../../..",
+        "args": {
+            "SDK_TAG": "v0.4.1"
+        }
     },
     "features": {
         "ghcr.io/devcontainers/features/git:1.1.5": {