Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license headers and fix pre-commit #112

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Update license headers and fix pre-commit #112

merged 11 commits into from
Jan 11, 2024

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Nov 26, 2023 •
edited
Loading

Describe your changes

Update license headers and fix pre-commit

Issue ticket number and link

ADO#17300

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@kse3hi kse3hi requested review from MP91 and BjoernAtBosch November 26, 2023 11:53
@kse3hi kse3hi self-assigned this Nov 26, 2023
BjoernAtBosch
BjoernAtBosch reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing of .gitignore and corresponding pre-commit stuff required

.pre-commit-config.yaml Outdated Show resolved Hide resolved
examples/dog-mode/src/vehicle_model/proto/hvac_pb2.py Outdated Show resolved Hide resolved
.project-creation/run.py Outdated Show resolved Hide resolved
MP91
MP91 requested changes Jan 11, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.project-creation/run.py Outdated Show resolved Hide resolved
examples/dog-mode/src/vehicle_model/proto/hvac_pb2.py Outdated Show resolved Hide resolved
velocitas_sdk/proto/broker_pb2.pyi Outdated Show resolved Hide resolved
velocitas_sdk/proto/collector_pb2.pyi Outdated Show resolved Hide resolved
velocitas_sdk/py.typed Outdated Show resolved Hide resolved
@dennismeister93
PR review findings
f218a2b 
Signed-off-by: Dennis Meister <[email protected]>
MP91
MP91 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 merged commit 5504400 into main Jan 11, 2024
9 checks passed
@dennismeister93 dennismeister93 deleted the fix/license_headers branch January 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP91 MP91 MP91 approved these changes

@BjoernAtBosch BjoernAtBosch Awaiting requested review from BjoernAtBosch

@mml5bg mml5bg Awaiting requested review from mml5bg

Assignees

@kse3hi kse3hi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kse3hi @MP91 @BjoernAtBosch @dennismeister93