feat(graphs): New Edge Attribute: AttributeFromNode #62
+133
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mario Santa Cruz <[email protected]>
Co-authored-by: Mario Santa Cruz <[email protected]>
Co-authored-by: Mario Santa Cruz <[email protected]>
Co-authored-by: Mario Santa Cruz <[email protected]>
…edge_attr_from_node_attr
|
|
icedoom888
changed the title
JPXKQX
requested changes
Jan 15, 2025
| @@ -14,6 +14,9 @@ Keep it human-readable, your future self will thank you! | |||
|
|
|||
| ### Added | |||
|
|
|||
| - feat: Add `AttributeFromSourceNode` and `AttributeFromTargetNode` edge attribute to copy attribute from source or target node. Set `node_attr_name` in the config to specify which attribute to copy from the source | target node (#94) | |||
|
|
|||
| # Changed | |||
| target_name: hidden | ||
| edge_builders: ... | ||
| attributes: | ||
| cutout: # Assigned name to the edge attribute, can be different than node_attr_name |
There was a problem hiding this comment.
Can we use something more meaningful as an example? comes_from_cutout, from_cutout, ...
| target_name: data | ||
| edge_builders: ... | ||
| attributes: | ||
| cutout: # Assigned name to the edge attribute, can be different than node_attr_name |
| @@ -35,9 +36,9 @@ def post_process(self, values: np.ndarray) -> torch.Tensor: | |||
| if values.ndim == 1: | |||
| values = values[:, np.newaxis] | |||
|
|
|||
| normed_values = self.normalise(values) | |||
| norm_values = self.normalise(values) | |||
There was a problem hiding this comment.
norm_values can refer to the norm of the values. If you think normed_values is confusing, I suggest we use normalised_values or we just overwrite values.
| super().__init__(norm=None, dtype="bool") | ||
|
|
||
|
|
||
| class AttributeFromNode(BooleanBaseEdgeAttribute, ABC): |
There was a problem hiding this comment.
Can we add the prefix Base? to make it clear that this class should not be instantiated.
| @@ -263,7 +263,7 @@ class CutOutMask(BooleanBaseNodeAttribute): | |||
|
|
|||
| def get_raw_values(self, nodes: NodeStorage, **kwargs) -> np.ndarray: | |||
| assert isinstance(nodes["_dataset"], dict), "The 'dataset' attribute must be a dictionary." | |||
| assert "cutout" in nodes["_dataset"], "The 'dataset' attribute must contain a 'cutout' key." | |||
| assert "cutout" in nodes["_dataset"] or "multivariablecutout" in nodes["_dataset"], "The 'dataset' attribute must contain a 'cutout' key." | |||
There was a problem hiding this comment.
I think this change is not in line with this PR.
JPXKQX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42