-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of NormalizedReluBounding for non-zero thresholds #64
base: develop
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…nemoi-models into feature/normalized_relu_bounding
for more information, see https://pre-commit.ci
…eature/normalized_relu_bounding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Could you add an example in the config? E.g.
- _target_: anemoi.models.layers.bounding.NormalizedReluBounding
variables: [sst]
min_val: [-2]
normalizer: ['mean-std']
Could be also commented out.
Thank you, @jakob-schloer. I have added the commented example in the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! Thanks for including my suggestions.
(pull request already under review in the anemoi-models repository)
This new approach can be used when applying the Relu bounding to a threshold value other than the default 0. An obvious use case is the ocean temperature, which should not go below the freezing temperature of the ocean (approx. 271.15 K). The threshold imputed to the function is normalised according to the normalisation scheme specified in the config file.
Here is an example call to be added to the config:
In case of multiple variables