feature(models): Add model comm group to predict_step #77
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
previously approved these changes
Jan 14, 2025
gmertes
reviewed
Jan 15, 2025
| @@ -94,7 +96,7 @@ def _build_model(self) -> None: | |||
| # Use the forward method of the model directly | |||
| self.forward = self.model.forward | |||
|
|
|||
| def predict_step(self, batch: torch.Tensor) -> torch.Tensor: | |||
| def predict_step(self, batch: torch.Tensor, model_comm_group: Optional[ProcessGroup] = None) -> torch.Tensor: | |||
There was a problem hiding this comment.
Can we also add a **kwargs here for future proofing? Then we don't need any logic in inference to maintain backwards compatibility when new optionals are added.
There was a problem hiding this comment.
It would be my pleasure. And then pass that to self()?
There was a problem hiding this comment.
I would not pass it to self, so that that remains explicit. Passing kwargs blindly to sub-functions is something we should try to avoid in general.
HCookie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow predict_step to take an optional model_comm_group, like model.forward does.
This is needed for parallel-inference, which calls predict_step