Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ORCA source grids #47

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Add support for ORCA source grids #47

merged 1 commit into from
Dec 8, 2024

Conversation

sandorkertesz
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@da1bee1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage        ?   92.09%           
=======================================
  Files           ?        7           
  Lines           ?      253           
  Branches        ?        7           
=======================================
  Hits            ?      233           
  Misses          ?       18           
  Partials        ?        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandorkertesz sandorkertesz merged commit cacf289 into main Dec 8, 2024
106 checks passed
@sandorkertesz sandorkertesz deleted the feature/orca branch December 8, 2024 13:26

The ``grid`` format is::

eORCAXXX_subtype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ORCA grids also include a version without the "e" prefix, I think I mistakenly mentioned "W". So the full list of recognized grids is

  • ORCA025_[FTUV]
  • ORCA12_[FTUV]
  • ORCA1_[FTUV]
  • ORCA2_[FTUV]
  • eORCA025_[FTUV]
  • eORCA12_[FTUV]
  • eORCA1_[FTUV]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants