Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing optional, added levtype/category for ocean and fixed typo #42

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

stefaniereuter
Copy link
Contributor

closed the other PR and this is the correct PR. (Sorry I missed that other changes were included on the other branch)

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 22.91%. Comparing base (2c8d22a) to head (bf6f75e).

Files with missing lines Patch % Lines
...o/action/statistics/cfg/StatisticsConfiguration.cc 33.33% 4 Missing ⚠️
src/multio/message/MetadataException.cc 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
- Coverage    22.92%   22.91%   -0.01%     
===========================================
  Files          291      292       +1     
  Lines        30573    30582       +9     
  Branches      1166     1169       +3     
===========================================
  Hits          7009     7009              
- Misses       23564    23573       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 - Fix missing optional
 - Add levtype/category for ocean
 - Fix typo
@dsarmany dsarmany force-pushed the hotfix/2.2-statistic-action branch from 4a7bc2a to bf6f75e Compare December 2, 2024 07:36
@dsarmany dsarmany merged commit c70c09e into develop Dec 4, 2024
361 of 364 checks passed
@dsarmany dsarmany deleted the hotfix/2.2-statistic-action branch December 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants