Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an assert that there are less than 2^16 unique strings in a column #17

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

TomHodson
Copy link
Contributor

There is no ODC codec to handle the case of there being more than 2^16 unique strings in a column so this just adds a guard assert. Also fixes the formatting.

@FussyDuck
Copy link

FussyDuck commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

@simondsmart
Copy link
Contributor

Note that this should never be hit in practice, as the number of rows is (by default) constrained to 10k.

@simondsmart
Copy link
Contributor

can you also fix the weird indenting. Then merge.

@TomHodson TomHodson force-pushed the bugfix/guard-against-too-many-strings branch from a20e1ee to 8c19e91 Compare July 31, 2024 14:32
@TomHodson TomHodson force-pushed the bugfix/guard-against-too-many-strings branch from 8c19e91 to 7cbe8d4 Compare July 31, 2024 14:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (5fe161e) to head (7cbe8d4).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
- Coverage    87.30%   87.28%   -0.02%     
===========================================
  Files          189      189              
  Lines        15020    14928      -92     
  Branches         0     1352    +1352     
===========================================
- Hits         13113    13030      -83     
+ Misses        1907     1898       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants