Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ignore GO-2024-3166 in govulncheck #3404

Merged
merged 3 commits into from
Oct 11, 2024
Merged

ci: ignore GO-2024-3166 in govulncheck #3404

merged 3 commits into from
Oct 11, 2024

Conversation

burgerdev
Copy link
Contributor

Context

govulncheck shows a finding in a transitive dependency of sigstore/rekor. According to sigstore/rekor#2237, this is a false-positive. Unfortunately, govulncheck does not support ignoring findings.

Proposed change(s)

  • Parse the findings manually from JSON output, ignoring known false-positives.

Checklist

  • Add labels (e.g., for changelog category)
  • Is PR title adequate for changelog?
  • Link to Milestone

@burgerdev burgerdev added the no changelog Change won't be listed in release changelog label Oct 11, 2024
@burgerdev burgerdev added this to the v2.19.0 milestone Oct 11, 2024
@burgerdev burgerdev requested a review from msanft October 11, 2024 10:56
@burgerdev burgerdev requested a review from katexochen as a code owner October 11, 2024 10:56
@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 56c7a27
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/670922e656cedb0008e327ed

katexochen
katexochen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess upstream issue is golang/go#61211

msanft
msanft reviewed Oct 11, 2024
View reviewed changes
bazel/ci/govulncheck.sh.in Outdated Show resolved Hide resolved
@burgerdev burgerdev merged commit 60dcac1 into main Oct 11, 2024
6 checks passed
@burgerdev burgerdev deleted the burgerdev/govulncheck branch October 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msanft msanft msanft approved these changes

@katexochen katexochen katexochen approved these changes

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@burgerdev @katexochen @msanft