Resolve BeautifulSoup Parser Warning and Unhandled Exception #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request fixes a warning thrown by BeautifulSoup and an error condition that causes the program to crash due to an unhandled exception.
Approach
When ran, the program would display the following error message:
BeautifulSoup recommends using lxml as a faster parser, so I've added lxml to the requirements file and to the BeautifulSoup call.
Regarding the unhandled exception, it appears that some items caught by the crawler identify as podcasts, but do no have feedURLs, which causes the program to throw a
KeyError
exception, which was previously unhandled causing the application to crash.I've wrapped the JSON loading in a try/except to catch the exception and have the function return
None
in the case that the JSON doesn't include a feedURL. Of course, this means that the function callingpodcast_from_json()
needed to be able to deal withNone
being returned, so I modified that function to only add a Podcast object to the list if it was notNone
.