feat: control linked account by settings (#675) #802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: control linked account by settings This feature allows to control the tab linked_accounts in account settings to appear or not. Is controlled using `SHOW_LINKED_ACCOUNTS` (cherry picked from commit 7d43718042414d4e736d1c225cb9008c363dfbd3) (cherry picked from commit 6fef8d1ca7efe1b87602a764a8cbe62c880f623b) * feat: PR improvements - doblequotes for dosctring - avoid jump of line if its not necessary (cherry picked from commit ae27a15)
|
CLosed in favour of nelc/edx-platform#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration to palm
This feature allows to control the tab linked_accounts in account settings to appear or not. Is controlled using
SHOW_LINKED_ACCOUNTS(cherry picked from commit 7d43718042414d4e736d1c225cb9008c363dfbd3) (cherry picked from commit 6fef8d1ca7efe1b87602a764a8cbe62c880f623b)
(cherry picked from commit ae27a15)
Testing instructions
Deactivate mfe account settings. This change is only for the base or classic account settings view. Mfe doesnt works.
Deactivate via the django waffle flag or using django site config or eox-tenant if you have it.
SHOW_LINKED_ACCOUNTS = Falsehttps://github.com/eduNEXT/edunext-platform/blob/ednx-release/palma.master.nelp/openedx/core/djangoapps/user_api/accounts/toggles.py#L42
Check the linked account in the
/account/settings/view is not presented.Before
AFter
Please provide detailed step-by-step instructions for testing this change.