-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new tenant setting to enable the Course Authoring MFE #808
feat: add a new tenant setting to enable the Course Authoring MFE #808
Conversation
ea1c9d5
to
32d9485
Compare
@bra-i-am I already approved it, but please make sure that tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking the behavior in Brayan's environment, that works as expected.
4075dbe
to
276b035
Compare
276b035
to
44f230c
Compare
* fix: modify some test to be according to the new behavior
44f230c
to
4232a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Looks good to me! ✨
Depends on
boolean
values in the tenantsuse_course_authoring_mfe
util to the required templateDescription
This PR creates a handler for a new setting
ENABLE_COURSE_AUTHORING_MFE
that will allow to enable or disable the course authoring MFE according to the settings of the tenantFor you to take it into account, there is a set of tests failing that doesn't belong to the changes applied in this PR. Next, I let evidence of the tests ran in the base release branch
ednx-release/palma.master
and they are even failing there:Supporting information
JIRA Issue DS-805
Testing instructions
Local
tutor plugins install mfe
, and enable ittutor plugins enable mfe
tutor config save
to make the two above bullets availabletutor mounts add lms,cms:/path/to/eox-tenant/clone:/openedx/extra-deps/eox-tenant
tutor dev/local launch
tutor dev exec lms/cms bash
, install eox-tenantpip install -e .../extra-deps/eox-tenant
, and run the migrations./manage.py lms makemigrations
and./manage.py lms migrate
tutor dev restart
tenantA
and the other one with the organizationtenantB
ENABLE_COURSE_AUTHORING: false
, you have to see the legacy 'Pages' section...... but, if you have the flag as
ENABLE_COURSE_AUTHORING: true
, then you'll see the MFE directioner, but this will point to the tenant-bStage
First, meanwhile the PRs are approved, make sure that the 'TARGET REVISION' in ArgoCD is pointing to the branch
bc/test_course_authoring_setting
of the manifestThen make sure there are tenant configs one with
ENABLE_COURSE_AUTHORING_MFE=true
and another withfalse
and start testing from 11 bullet in the above section