Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uploading and deleting the same assets #15

Closed
wants to merge 1 commit into from

Conversation

johnvente
Copy link
Contributor

Description

When we delete an asset and upload it at the same time, the asset won't appear anymore because it was deleted. With this fix, delete the asset first and then upload it, which means the operations are inverted now

BEFORE NOW

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@johnvente johnvente closed this Oct 18, 2023
@mariajgrimaldi mariajgrimaldi deleted the jv/fix-delete-and-save-same-asset branch November 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant