feat: eslint + Typescript config

[johnvente]

Configuration for Eslint and Typescript

Eslint: It has some rules React app code

Two new scripts:

• lint to check if there any error

   yarn lint
  

• lint-fix to fix the errors found

   yarn lint
  

Merge checklist:
Check off if complete or not applicable:

• Version bumped
• Changelog record added
• Documentation updated (not only docstrings)
• Fixup commits are squashed away
• Unit tests added/updated
• Manual testing instructions provided
• Noted any: Concerns, dependencies, migration issues, deadlines, tickets

[mariajgrimaldi]

We should have a GH action that runs yarn lint then, shouldn't we?

[johnvente]

We should have a GH action that runs yarn lint then, shouldn't we?

Yep, we should have it, I'll add it
@mariajgrimaldi done!

[mariajgrimaldi]

Also, why do we need typescript? Isn't that adding more complexity to the implementation?

[johnvente]

Also, why do we need typescript? Isn't that adding more complexity to the implementation?

I will need to type props for the components, I can use prop-types lib but it will be better to use Typescript for maintaining this and for types in general. It wouldn't add more complexity

[mariajgrimaldi]

If you don't mind me asking, why are prop types needed?

[johnvente]

If you don't mind me asking, why are prop types needed?

When we upload a file, there will be a list of images each image will be a component (needs props), list of images will be another component (needs prop with the list of images). It's a good practice to type props and types that in this case I will use a context as well

[mariajgrimaldi]

But does the library need types? Is adding typescript making the library more or less maintainable? Can we elaborate on it?
cc @felipemontoya

[johnvente]

maintainable

Typescript makes the React app more maintainable, there is not a problem adding it. Why is there problem with this?

[felipemontoya]

Because we have so far had problems with every extra type of javascript language that we add to the stack. Adding coffescript was a nightmare when it promised to make everything easier. We are already suspicious of adding new variants of Javascript. It usually makes whatever we are doing harder to maintain in the long term.

[mariajgrimaldi]

I'm gonna move this back to draft in case we need it in the future