Refactor/replace environments by substitution #787
Merged
+386
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of
const start_7 = (start_6 - (1));
const acc_10 = new Cons_0(tmp_32, acc_9);
start_6 = start_7;
acc_9 = acc_10;
continue toList_worker_3;
we now genereate
const tmp_start_0 = start_0;
const tmp_acc_0 = acc_0;
start_0 = (tmp_start_0 - (1));
acc_0 = new Cons_0(tmp_2, tmp_acc_0);
continue toList_worker_0;
when translating tail calls.
b-studios
commented
Jan 22, 2025
|
|
||
| case cps.Stmt.Resume(r, b, ks2, k2) => | ||
| pure(js.Return(js.Call(RESUME, nameRef(r), toJS(b)(using nonrecursive(b)), toJS(ks2), toJS(k2)))) | ||
| pure(js.Return(js.Call(RESUME, nameRef(r), toJS(b)(using nonrecursive(b)), toJS(ks2), requiringThunk { toJS(k2) }))) |
There was a problem hiding this comment.
This might slow down some benchmarks, but is necessary in the general case to avoid SOs
b-studios
commented
Jan 22, 2025
| val a = Id("a") | ||
| val ks = Id("ks") | ||
| cps.Cont.ContLam(a, ks, cps.Hole()) | ||
| } |
There was a problem hiding this comment.
This needs to be replaced by a specialized error continuation
b-studios
commented
Jan 22, 2025
| @@ -21,6 +21,8 @@ object Optimizer extends Phase[CoreTransformed, CoreTransformed] { | |||
|
|
|||
| def optimize(source: Source, mainSymbol: symbols.Symbol, core: ModuleDecl)(using Context): ModuleDecl = | |||
|
|
|||
| val isLLVM = Context.config.backend().name == "llvm" | |||
There was a problem hiding this comment.
This is REALLY hacky. Another solution would be to first optimize and then do polymorphism boxing. However, this alternative currently (I didn't try to find out why) fails a lot of test.
b-studios
commented
Jan 22, 2025
| patternMatches = 0, | ||
| branches = 5, | ||
| pushedFrames = 531467, | ||
| poppedFrames = 531467, | ||
| allocations = 0, | ||
| closures = 265750, | ||
| closures = 26, |
There was a problem hiding this comment.
This change is particularly significant...
b-studios
commented
Jan 22, 2025
| case (tpe1, TTop) => true | ||
| case (TBottom, tpe1) => true | ||
| case _ => false // conservative :) | ||
| // sys error s"Cannot compare ${tpe1} ${tpe2} in ${covariant}" // conservative :) |
There was a problem hiding this comment.
If you ever want to fix more bugs, comment this in again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.