Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game UI features #145

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Game UI features #145

wants to merge 16 commits into from

Conversation

vEnhance
Copy link

@vEnhance vEnhance commented Nov 8, 2022

Create links on the text bottom for toggling card layout

New client-side option to show hotkeys in a corner near the card, which can also
be similarly toggled on and off

@vEnhance
Copy link
Author

vEnhance commented Nov 8, 2022

Screenshot:

image

@vEnhance vEnhance marked this pull request as ready for review November 8, 2022 21:25
Copy link
Contributor

@HiddeKoerts HiddeKoerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice additions to make the more advanced interactions with the site more visible to the average user.

I think adding buttons for rotating the orientation and rotating the cards is very good. It works well and fits with the design language of the website.

I'm less convinced by the keyboard visualization. A few comments:

  • 'Toggle keys' seems to indicate that the keyboard shortcuts themselves are enabled/disabled by pressing that button. I'd change it to something like 'Show keys' or something along those lines.
  • The font used for indicating the keys seems inconsistent with the rest of the website. Please change it to a font that is used elsewhere as well.
  • There seem to be some positioning issues. When playing around with the aspect ratio and size of the browser window, it seems to be a frequent occurrence that the letters indicating the keys overlap the boundaries of the cards significantly. For example:
    image

Honestly, I think that the keyboard shortcuts for cards should be intuitive enough that one look at the 'Help' section should explain everything that's needed. Nevertheless I also see the value of this feature for making shortcuts more visible and helping people right at the beginning of switching to keyboard.

@vEnhance
Copy link
Author

saw that development on this repo is starting back up again, so i'll try to bring this PR up to date at some point in january once i'm back in boston (at which point i'll probably drop the keyboard shortcut labels as suggested)

@vEnhance
Copy link
Author

vEnhance commented Jan 5, 2025

Updated the PR and merged in main. Only left the two links for card layout and dropped the keyboard thingy entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants