Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add probes for memfd_create and friends #185

Merged
merged 14 commits into from
May 29, 2024
Merged

Add probes for memfd_create and friends #185

merged 14 commits into from
May 29, 2024

Conversation

stanek-michal
Copy link
Contributor

New events added:

EBPF_EVENT_FILE_MEMFD_OPEN
EBPF_EVENT_FILE_SHMEM_OPEN
EBPF_EVENT_PROCESS_MEMFD_CREATE
EBPF_EVENT_PROCESS_SHMGET
EBPF_EVENT_PROCESS_PTRACE
EBPF_EVENT_PROCESS_LOAD_MODULE

Also added new fields to process exec event

@stanek-michal stanek-michal requested a review from a team as a code owner March 19, 2024 01:30
nicholasberlin
nicholasberlin reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few questions.

GPL/Events/File/Probe.bpf.c Show resolved Hide resolved
GPL/Events/File/Probe.bpf.c Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
GPL/Events/Helpers.h Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
nicholasberlin
nicholasberlin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works

mjwolf
mjwolf approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multi-kernel tester has a failing test with this, I didn't look into the exact cause, but this LGTM, once the tests are fixed

@stanek-michal
Copy link
Contributor Author

The multi-kernel tester has a failing test with this, I didn't look into the exact cause, but this LGTM, once the tests are fixed

turned out it was a missing break in a switch block in EventsTrace that sometimes would trigger memory corruption and fail the multi-kernel tests. Fixed now and rebased, rerunning CI

haesbaert
haesbaert requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@haesbaert haesbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

haesbaert
haesbaert requested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@haesbaert haesbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some very minor thingies

GPL/Events/EbpfEventProto.h Outdated Show resolved Hide resolved
GPL/Events/EbpfEventProto.h Outdated Show resolved Hide resolved
GPL/Events/Helpers.h Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
GPL/Events/Process/Probe.bpf.c Outdated Show resolved Hide resolved
cmake/modules/setup.cmake Show resolved Hide resolved
@haesbaert
Copy link
Contributor

Looking swell!

@stanek-michal stanek-michal merged commit 61bdb7f into main May 29, 2024
24 of 26 checks passed
@stanek-michal stanek-michal deleted the memfd_probes branch May 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasberlin nicholasberlin nicholasberlin approved these changes

@mjwolf mjwolf mjwolf approved these changes

@haesbaert haesbaert haesbaert approved these changes

Assignees
No one assigned
Labels
please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stanek-michal @haesbaert @mjwolf @nicholasberlin